Update editorconfig rules for VS2017.

Most of VS2017's defaults are kept, but they're made explicit in this file so it doesn't matter if the defaults have been changed locally.

Author: bgrainger

.editorconfig

@@ -1,12 +1,68 @@
+root = true
+
 [*]
-end_of_line = lf
 charset = utf-8
-indent_style = tab
-insert_final_newline = true
+indent_style = space
+indent_size = 2
 trim_trailing_whitespace = true
+insert_final_newline = true
+end_of_line = lf
+
+[*.csproj]
+insert_final_newline = false
 
 [*.cs]
+indent_style = tab
 indent_size = 4
 
-[*.json]
-indent_size = 2
+# changes from VS2017 defaults
+csharp_style_expression_bodied_methods = true:suggestion
+csharp_style_expression_bodied_constructors = true:suggestion
+csharp_style_expression_bodied_operators = true:suggestion
+csharp_prefer_braces = false:none
+csharp_indent_switch_labels = false
+csharp_space_after_cast = true
+csharp_preserve_single_line_statements = false
+
+# use VS2017 defaults, but make them warnings (instead of none)
+dotnet_style_qualification_for_field = false:warning
+dotnet_style_qualification_for_property = false:warning
+dotnet_style_qualification_for_method = false:warning
+dotnet_style_qualification_for_event = false:warning
+dotnet_style_predefined_type_for_locals_parameters_members = true:warning
+dotnet_style_explicit_tuple_names = true:warning
+dotnet_style_coalesce_expression = true:warning
+
+# use VS2017 defaults, but make them suggestions (instead of none)
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
+csharp_style_expression_bodied_properties = true:suggestion
+csharp_style_expression_bodied_indexers = true:suggestion
+csharp_style_expression_bodied_accessors = true:suggestion
+
+# explicitly use VS2017 defaults
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+dotnet_sort_system_directives_first = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_within_query_expression_clauses = true
+csharp_indent_case_contents = true
+csharp_indent_labels = one_less
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_preserve_single_line_blocks = true