Skip to content

Testing everything on both Vibe and Phobos sockets is 90% redundant. #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Abscissa opened this issue May 5, 2018 · 0 comments
Closed
Labels

Comments

@Abscissa
Copy link

Abscissa commented May 5, 2018

The Vibe/Phobos socket abstraction is pretty well encapsulated, has proved to be solid for several years, and I'm not aware of even one single time a test failure (beyond the basic connecting to a server) has ever been specific to one type of socket or the other.

Therefore, I don't think the entire test suite needs to be repeated for both Vibe and Phobos sockets anymore. When both Vibe and Phobos sockets are being tested, one of them can be reduced to a smaller set of "core" tests just to ensure the the sockets themselves are working (probably just making sure it can establish a connection to the server).

This would (safely) make a drastic reduction in testing time, and reduce unnecessary load on travis-ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant