Skip to content

Commit 11fd3f1

Browse files
committed
Ensure correct spacing between ticklabels and ticks when using drawminorticklabel
1 parent e5725c6 commit 11fd3f1

File tree

1 file changed

+21
-4
lines changed

1 file changed

+21
-4
lines changed

src/plots/cartesian/axes.js

+21-4
Original file line numberDiff line numberDiff line change
@@ -3150,14 +3150,31 @@ axes.makeLabelFns = function(ax, shift, angle) {
31503150
var isAligned = isBottom || isLeft || isTop || isRight;
31513151

31523152
var insideTickLabels = has('inside');
3153-
var labelsOverTicks =
3154-
(ticklabelposition === 'inside' && ax.ticks === 'inside') ||
3155-
(!insideTickLabels && ax.ticks === 'outside' && ax.tickson !== 'boundaries');
3153+
3154+
var minorTicksInside = ax.minor && ax.minor.ticks === 'inside';
3155+
var minorTicksOutside = ax.minor && ax.minor.ticks === 'outside';
3156+
3157+
var labelsOverMajorTicks = false;
3158+
var labelsOverMinorTicks = false;
3159+
if(insideTickLabels) {
3160+
if(ax.ticks === 'inside') {
3161+
labelsOverMajorTicks = true;
3162+
} else if(minorTicksInside) {
3163+
labelsOverMinorTicks = true;
3164+
}
3165+
} else {
3166+
if(ax.ticks === 'outside' && ax.tickson !== 'boundaries') {
3167+
labelsOverMajorTicks = true;
3168+
} else if(minorTicksOutside) {
3169+
labelsOverMinorTicks = true;
3170+
}
3171+
}
3172+
var labelsOverTicks = labelsOverMajorTicks || labelsOverMinorTicks;
31563173

31573174
var labelStandoff = 0;
31583175
var labelShift = 0;
31593176

3160-
var tickLen = labelsOverTicks ? ax.ticklen : 0;
3177+
var tickLen = labelsOverMajorTicks ? ax.ticklen : labelsOverMinorTicks ? ax.minor.ticklen : 0;
31613178
if(insideTickLabels) {
31623179
tickLen *= -1;
31633180
} else if(isAligned) {

0 commit comments

Comments
 (0)