fix(WatchGroup): Handle watching elements of array that were removed.

Closes dart-archive#1046

Author: mvuksano

lib/change_detection/ast_parser.dart

@@ -193,7 +193,11 @@ _operation_logical_and(left, right)            => toBool(left) && toBool(right);
 _operation_logical_or(left, right)             => toBool(left) || toBool(right);
 
 _operation_ternary(condition, yes, no) => toBool(condition) ? yes : no;
-_operation_bracket(obj, key) => obj == null ? null : obj[key];
+_operation_bracket(obj, key) {
+  if (obj is! List || (key is int && key >= 0 && key < obj.length)) {
+    return obj[key];
+  }
+}
 
 class ArrayFn extends FunctionApply {
   // TODO(misko): figure out why do we need to make a copy?

test/directive/ng_repeat_spec.dart

@@ -327,7 +327,6 @@ main() {
       expect(element.text).toEqual('misko:0|shyam:1|frodo:2|');
     });
 
-
     it(r'should expose iterator position as $first, $middle and $last when iterating over arrays',
         () {
       element = compile(
@@ -401,6 +400,54 @@ main() {
       expect(element.text).toEqual('a|b|Xc|d|X');
     });
 
+    describe('nested watching', () {
+      it('should not error when the first item is being watched and it is removed', () {
+        element = compile(
+            '<ul>'
+            '  <li ng-repeat="i in items">'
+            '    <input ng-model="items[\$index]">'
+            '  </li>'
+            '</ul>');
+        scope.context['items'] = ['misko', 'shyam', 'frodo'];
+        scope.apply();
+        expect(element.children.length).toEqual(3);
+        scope.context['items'].remove('misko');
+        scope.apply();
+        expect(element.children.length).toEqual(2);
+      });
+
+      it('should not error when the last item is being watched and it is removed', () {
+        element = compile(
+            '<ul>'
+            '  <li ng-repeat="i in items">'
+            '    <input ng-model="items[\$index]">'
+            '  </li>'
+            '</ul>');
+        scope.context['items'] = ['misko', 'shyam', 'frodo'];
+        scope.apply();
+        expect(element.children.length).toEqual(3);
+        scope.context['items'].remove('frodo');
+        scope.apply();
+        expect(element.children.length).toEqual(2);
+      });
+
+      it('should not error when an items are being watched and multiple items are removed '
+      'at the same time', () {
+        element = compile(
+            '<ul>'
+            '  <li ng-repeat="i in items">'
+            '    <input ng-model="items[\$index]">'
+            '  </li>'
+            '</ul>');
+        scope.context['items'] = ['misko', 'shyam', 'frodo', 'igor'];
+        scope.apply();
+        expect(element.children.length).toEqual(4);
+        scope.context['items'].remove('shyam');
+        scope.context['items'].remove('frodo');
+        scope.apply();
+        expect(element.children.length).toEqual(2);
+      });
+    });
 
     describe('stability', () {
       var a, b, c, d, lis;
@@ -420,7 +467,6 @@ main() {
         lis = element.querySelectorAll('li');
       });
 
-
       it(r'should preserve the order of elements', () {
         scope.context['items'] = [a, c, d];
         scope.apply();