BUG: Any/All sometimes does not return boolean (pandas-dev#12863)

Author: mroeschke

pandas/core/nanops.py

@@ -259,14 +259,20 @@ def _wrap_results(result, dtype):
 
 
 def nanany(values, axis=None, skipna=True):
+    import pdb; pdb.set_trace()
     values, mask, dtype, _ = _get_values(values, skipna, False, copy=skipna)
-    return values.any(axis)
-
+    if is_object_dtype(dtype):
+        return any(values)
+    else:
+        return values.any(axis)
 
 def nanall(values, axis=None, skipna=True):
+    import pdb; pdb.set_trace()
     values, mask, dtype, _ = _get_values(values, skipna, True, copy=skipna)
-    return values.all(axis)
-
+    if is_object_dtype(dtype):
+        return any(values)
+    else:
+        return values.any(axis)
 
 @disallow('M8')
 @bottleneck_switch(zero_value=0)

pandas/tests/series/test_analytics.py

@@ -596,16 +596,28 @@ def test_all_any(self):
 
         # Alternative types, with implicit 'object' dtype.
         s = Series(['abc', True])
-        self.assertEqual('abc', s.any())  # 'abc' || True => 'abc'
+        self.assertEqual(True, s.any())
+        self.assertEqual(True, s.all())
+        s = Series(['abc', False])
+        self.assertEqual(True, s.any())
+        self.assertEqual(False, s.all())
+        # GH 12863
+        s = Series(data=list('abcde'), dtype=object)
+        self.assertTrue(s.any())
+        self.assertTrue(s.all())
 
     def test_all_any_params(self):
         # Check skipna, with implicit 'object' dtype.
         s1 = Series([np.nan, True])
         s2 = Series([np.nan, False])
         self.assertTrue(s1.all(skipna=False))  # nan && True => True
         self.assertTrue(s1.all(skipna=True))
-        self.assertTrue(np.isnan(s2.any(skipna=False)))  # nan || False => nan
+        self.assertTrue(s1.any(skipna=False))
+        self.assertTrue(s1.any(skipna=True))
         self.assertFalse(s2.any(skipna=True))
+        self.assertTrue(s2.any(skipna=False))
+        self.assertFalse(s2.all(skipna=True))
+        self.assertFalse(s2.all(skipna=False))
 
         # Check level.
         s = pd.Series([False, False, True, True, False, True],