Skip to content

Commit 89c9f25

Browse files
committed
Try less hacky way
1 parent add23a5 commit 89c9f25

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.github/workflows/package-checks.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ jobs:
3838
with:
3939
python-version: '3.8'
4040

41-
# Can take a significant amount of time while this should only check that
42-
# the extras are installed
43-
- name: Disable building ext_modules
44-
run: |
45-
sed -i '/ext_modules=/d' setup.py
46-
shell: bash -el {0}
41+
# # Can take a significant amount of time while this should only check that
42+
# # the extras are installed
43+
# - name: Disable building ext_modules
44+
# run: |
45+
# sed -i '/ext_modules=/d' setup.py
46+
# shell: bash -el {0}
4747

4848
- name: Install required dependencies
4949
run: |
@@ -52,5 +52,5 @@ jobs:
5252

5353
- name: Pip install with extra
5454
run: |
55-
python -m pip install -e .[${{ matrix.extra }}] --no-build-isolation
55+
python -m pip install -e .[${{ matrix.extra }}] --no-build-isolation --install-option="no-extensions"
5656
shell: bash -el {0}

setup.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,10 @@ def maybe_cythonize(extensions, *args, **kwargs):
407407
# See https://github.com/cython/cython/issues/1495
408408
return extensions
409409

410+
elif "no-extensions" in sys.argv:
411+
# For pip install extras CI job in .github/workflows/package-checks.yml
412+
return []
413+
410414
elif not _CYTHON_INSTALLED:
411415
# GH#28836 raise a helfpul error message
412416
if _CYTHON_VERSION:

0 commit comments

Comments
 (0)