Skip to content

Commit 4e1d155

Browse files
phoflmroeschke
authored andcommitted
WARN: Remove non-actionable warning in value_counts (pandas-dev#54789)
1 parent 8bcc190 commit 4e1d155

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

pandas/core/frame.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7279,7 +7279,7 @@ def value_counts(
72797279
subset = self.columns.tolist()
72807280

72817281
name = "proportion" if normalize else "count"
7282-
counts = self.groupby(subset, dropna=dropna).grouper.size()
7282+
counts = self.groupby(subset, dropna=dropna, observed=False).grouper.size()
72837283
counts.name = name
72847284

72857285
if sort:

pandas/tests/frame/methods/test_value_counts.py

+14
Original file line numberDiff line numberDiff line change
@@ -175,3 +175,17 @@ def test_data_frame_value_counts_subset(nulls_fixture, columns):
175175
)
176176

177177
tm.assert_series_equal(result, expected)
178+
179+
180+
def test_value_counts_categorical_future_warning():
181+
# GH#54775
182+
df = pd.DataFrame({"a": [1, 2, 3]}, dtype="category")
183+
result = df.value_counts()
184+
expected = pd.Series(
185+
1,
186+
index=pd.MultiIndex.from_arrays(
187+
[pd.Index([1, 2, 3], name="a", dtype="category")]
188+
),
189+
name="count",
190+
)
191+
tm.assert_series_equal(result, expected)

0 commit comments

Comments
 (0)