Skip to content

Commit 588d701

Browse files
committed
Fix segfault in groupby-var
Previously we'd accidently call compute here when inferring metadata. The new groupby implementation segfaults when threads are used to compute the index (apparently), which could happen in some cases. It's easier just to let `aca` handle the metadata inference, so we'll remove it.
1 parent 99d0695 commit 588d701

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

dask/dataframe/groupby.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,10 @@ def mean(self):
251251

252252
@derived_from(pd.core.groupby.GroupBy)
253253
def var(self, ddof=1):
254-
from functools import partial
255-
meta = self.obj._meta
256-
if isinstance(meta, pd.Series):
257-
meta = meta.to_frame()
258-
meta = meta.groupby(self.index).var(ddof=1)
259254
result = aca([self.obj, self.index], chunk=_var_chunk,
260-
aggregate=partial(_var_agg, ddof=ddof), meta=meta,
261-
token=self._token_prefix + 'var')
255+
aggregate=_var_agg,
256+
token=self._token_prefix + 'var',
257+
aggregate_kwargs={'ddof': ddof})
262258

263259
if isinstance(self.obj, Series):
264260
result = result[result.columns[0]]

0 commit comments

Comments
 (0)