Skip to content

Commit e3965eb

Browse files
JuaniRiosacatangiuggwpez
authored andcommitted
Add pub to xcm::v4::PalletInfo (paritytech#4976)
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated 🙏🏻 --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
1 parent d0dbc9e commit e3965eb

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

polkadot/xcm/src/v4/mod.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,15 +231,15 @@ parameter_types! {
231231
#[derive(Clone, Eq, PartialEq, Encode, Decode, Debug, TypeInfo, MaxEncodedLen)]
232232
pub struct PalletInfo {
233233
#[codec(compact)]
234-
index: u32,
235-
name: BoundedVec<u8, MaxPalletNameLen>,
236-
module_name: BoundedVec<u8, MaxPalletNameLen>,
234+
pub index: u32,
235+
pub name: BoundedVec<u8, MaxPalletNameLen>,
236+
pub module_name: BoundedVec<u8, MaxPalletNameLen>,
237237
#[codec(compact)]
238-
major: u32,
238+
pub major: u32,
239239
#[codec(compact)]
240-
minor: u32,
240+
pub minor: u32,
241241
#[codec(compact)]
242-
patch: u32,
242+
pub patch: u32,
243243
}
244244

245245
impl TryInto<OldPalletInfo> for PalletInfo {

prdoc/pr_4976.prdoc

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
2+
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json
3+
4+
title: Add pub to xcm::v4::PalletInfo
5+
6+
doc:
7+
- audience: Runtime Dev
8+
description: |
9+
Forgot to make v4 PalletInfo fields public. Without them we cannot make use of the struct.
10+
11+
crates:
12+
- name: staging-xcm
13+
bump: patch
14+
validate: false
15+

0 commit comments

Comments
 (0)