From 386c676b8eec027ce615c25936918863328081b4 Mon Sep 17 00:00:00 2001 From: andreaangiolillo Date: Mon, 11 Mar 2024 11:26:45 +0000 Subject: [PATCH 1/4] CLOUDP-236543: Disable e2e_local_deployments --- build/ci/evergreen.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/build/ci/evergreen.yml b/build/ci/evergreen.yml index f30fc503a8..007f6c2373 100644 --- a/build/ci/evergreen.yml +++ b/build/ci/evergreen.yml @@ -1280,13 +1280,14 @@ buildvariants: <<: *go_linux_version tasks: - name: ".e2e .deployments .atlas" - - name: e2e_local_deployments - display_name: "E2E Local Deployments Tests" - run_on: - - rhel80-small - expansions: - <<: *go_linux_version - tasks: - - name: ".e2e .deployments .local" +# This variant will be enabled in CLOUDP-237038 +# - name: e2e_local_deployments +# display_name: "E2E Local Deployments Tests" +# run_on: +# - rhel80-small +# expansions: +# <<: *go_linux_version +# tasks: +# - name: ".e2e .deployments .local" include: - filename: build/ci/release.yml From efc04b62ceb9434dd35dbc16998b16eb2e0a79ad Mon Sep 17 00:00:00 2001 From: andreaangiolillo Date: Thu, 4 Jul 2024 17:07:17 +0100 Subject: [PATCH 2/4] chore: add staticcheck --- .github/workflows/code-health.yml | 84 ++++++++++++++++++------------- 1 file changed, 50 insertions(+), 34 deletions(-) diff --git a/.github/workflows/code-health.yml b/.github/workflows/code-health.yml index ad55ed43cd..caac7875b4 100644 --- a/.github/workflows/code-health.yml +++ b/.github/workflows/code-health.yml @@ -10,17 +10,17 @@ jobs: name: lint runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@v4 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' cache: false # see https://github.com/golangci/golangci-lint-action/issues/807 - name: golangci-lint - uses: golangci/golangci-lint-action@v6.0.1 + uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 with: version: v1.56.2 unit-tests: @@ -35,21 +35,21 @@ jobs: os: [ubuntu-latest, windows-latest, macos-latest] runs-on: ${{ matrix.os }} steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 if: ${{ matrix.os=='ubuntu-latest' }} with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - run: go install gotest.tools/gotestsum@latest - run: make unit-test - name: Test Summary id: test_summary - uses: test-summary/action@v2.4 + uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86 with: paths: unit-tests.xml if: always() && matrix.os == 'ubuntu-latest' @@ -61,13 +61,13 @@ jobs: INTEGRATION_TAGS: integration runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - run: go install gotest.tools/gotestsum@latest @@ -75,13 +75,13 @@ jobs: libraryOwners: runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - name: Run check-library-owners @@ -89,13 +89,13 @@ jobs: docs: runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - name: Generate docs @@ -116,10 +116,10 @@ jobs: actionlint: runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@v4 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Download actionlint id: get_actionlint run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) @@ -132,13 +132,13 @@ jobs: mocks: runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - name: Install go-mock @@ -162,22 +162,22 @@ jobs: name: shellcheck runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@v4 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Run ShellCheck - uses: bewuethr/shellcheck-action@v2 + uses: bewuethr/shellcheck-action@d01912909579c4b1a335828b8fca197fbb8e0aa4 tidy: runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - name: Run 'go mod tidy' @@ -199,12 +199,12 @@ jobs: name: licensecheck runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@v4 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - run: make devtools @@ -213,12 +213,28 @@ jobs: name: checktemplates runs-on: ubuntu-latest steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@v1 + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 with: config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@v4 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - name: Install Go - uses: actions/setup-go@v5 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 with: go-version-file: 'go.mod' - run: make check-templates + staticcheck: + runs-on: ubuntu-latest + steps: + - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 + with: + config: ${{ vars.PERMISSIONS_CONFIG }} + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 + with: + fetch-depth: 1 + - name: Install Go + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 + with: + go-version-file: 'go.mod' + - uses: dominikh/staticcheck-action@fe1dd0c3658873b46f8c9bb3291096a617310ca6 + with: + install-go: false \ No newline at end of file From 89b7561579121346c52057327ee71a27474850a9 Mon Sep 17 00:00:00 2001 From: andreaangiolillo Date: Thu, 4 Jul 2024 17:08:39 +0100 Subject: [PATCH 3/4] Update code-health.yml --- .github/workflows/code-health.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-health.yml b/.github/workflows/code-health.yml index caac7875b4..5bbe2673cb 100644 --- a/.github/workflows/code-health.yml +++ b/.github/workflows/code-health.yml @@ -237,4 +237,4 @@ jobs: go-version-file: 'go.mod' - uses: dominikh/staticcheck-action@fe1dd0c3658873b46f8c9bb3291096a617310ca6 with: - install-go: false \ No newline at end of file + install-go: false From 2e56d6b31b1ebed63ebf87342b29b6ac6a56674a Mon Sep 17 00:00:00 2001 From: andreaangiolillo Date: Thu, 4 Jul 2024 17:29:38 +0100 Subject: [PATCH 4/4] Update code-health.yml --- .github/workflows/code-health.yml | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/.github/workflows/code-health.yml b/.github/workflows/code-health.yml index 5bbe2673cb..a189052e1e 100644 --- a/.github/workflows/code-health.yml +++ b/.github/workflows/code-health.yml @@ -222,19 +222,4 @@ jobs: with: go-version-file: 'go.mod' - run: make check-templates - staticcheck: - runs-on: ubuntu-latest - steps: - - uses: GitHubSecurityLab/actions-permissions/monitor@e83639073897b68de235d81a783b2221cc13def7 - with: - config: ${{ vars.PERMISSIONS_CONFIG }} - - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - with: - fetch-depth: 1 - - name: Install Go - uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 - with: - go-version-file: 'go.mod' - - uses: dominikh/staticcheck-action@fe1dd0c3658873b46f8c9bb3291096a617310ca6 - with: - install-go: false +