SERVER-90571: Enable python formatting checks for buildscripts/idl directory (#22293)

GitOrigin-RevId: a2fbc8ed83f576703cce96ebb5e680cc70aac4d8

Author: smcclure15

buildscripts/idl/check_stable_api_commands_have_idl_definitions.py

@@ -40,7 +40,7 @@
 from pymongo import MongoClient
 
 # Permit imports from "buildscripts".
-sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), '../../..')))
+sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), "../../..")))
 
 # pylint: disable=wrong-import-position
 from idl import syntax
@@ -53,7 +53,7 @@
 from buildscripts.resmokelib.testing.fixtures.standalone import MongoDFixture
 # pylint: enable=wrong-import-position
 
-LOGGER_NAME = 'check-idl-definitions'
+LOGGER_NAME = "check-idl-definitions"
 LOGGER = logging.getLogger(LOGGER_NAME)
 
 
@@ -68,8 +68,9 @@ def is_test_or_third_party_idl(idl_path: str) -> bool:
     return False
 
 
-def get_command_definitions(api_version: str, directory: str,
-                            import_directories: List[str]) -> Dict[str, syntax.Command]:
+def get_command_definitions(
+    api_version: str, directory: str, import_directories: List[str]
+) -> Dict[str, syntax.Command]:
     """Get parsed IDL definitions of commands in a given API version."""
 
     LOGGER.info("Searching for command definitions in %s", directory)
@@ -109,22 +110,30 @@ def list_commands_for_api(api_version: str, mongod_or_mongos: str, install_dir:
         logger = loggers.new_fixture_logger("ShardedClusterFixture", 0)
         logger.parent = LOGGER
         fixture = fixturelib.make_fixture(
-            "ShardedClusterFixture", logger, 0, dbpath_prefix=dbpath.name,
-            mongos_executable=mongos_executable, mongod_executable=mongod_executable,
-            mongod_options={"set_parameters": {}})
+            "ShardedClusterFixture",
+            logger,
+            0,
+            dbpath_prefix=dbpath.name,
+            mongos_executable=mongos_executable,
+            mongod_executable=mongod_executable,
+            mongod_options={"set_parameters": {}},
+        )
 
     fixture.setup()
     fixture.await_ready()
 
     try:
         client = MongoClient(fixture.get_driver_connection_url())  # type: MongoClient
-        reply = client.admin.command('listCommands')  # type: Mapping[str, Any]
+        reply = client.admin.command("listCommands")  # type: Mapping[str, Any]
         commands = {
-            name
-            for name, info in reply['commands'].items() if api_version in info['apiVersions']
+            name for name, info in reply["commands"].items() if api_version in info["apiVersions"]
         }
-        logging.info("Found %s commands in API Version %s on %s", len(commands), api_version,
-                     mongod_or_mongos)
+        logging.info(
+            "Found %s commands in API Version %s on %s",
+            len(commands),
+            api_version,
+            mongod_or_mongos,
+        )
         return commands
     finally:
         fixture.teardown()
@@ -144,13 +153,16 @@ def assert_command_sets_equal(api_version: str, command_sets: Dict[str, Set[str]
     for other_name, other_commands in it:
         if commands != other_commands:
             if commands - other_commands:
-                LOGGER.error("%s has commands not in %s: %s", name, other_name,
-                             commands - other_commands)
+                LOGGER.error(
+                    "%s has commands not in %s: %s", name, other_name, commands - other_commands
+                )
             if other_commands - commands:
-                LOGGER.error("%s has commands not in %s: %s", other_name, name,
-                             other_commands - commands)
+                LOGGER.error(
+                    "%s has commands not in %s: %s", other_name, name, other_commands - commands
+                )
             raise AssertionError(
-                f"{name} and {other_name} have different commands in API Version {api_version}")
+                f"{name} and {other_name} have different commands in API Version {api_version}"
+            )
 
 
 def remove_skipped_commands(command_sets: Dict[str, Set[str]]):
@@ -173,10 +185,15 @@ def remove_skipped_commands(command_sets: Dict[str, Set[str]]):
 def main():
     """Run the script."""
     arg_parser = argparse.ArgumentParser(description=__doc__)
-    arg_parser.add_argument("--include", type=str, action="append",
-                            help="Directory to search for IDL import files")
-    arg_parser.add_argument("--install-dir", dest="install_dir", required=True,
-                            help="Directory to search for MongoDB binaries")
+    arg_parser.add_argument(
+        "--include", type=str, action="append", help="Directory to search for IDL import files"
+    )
+    arg_parser.add_argument(
+        "--install-dir",
+        dest="install_dir",
+        required=True,
+        help="Directory to search for MongoDB binaries",
+    )
     arg_parser.add_argument("-v", "--verbose", action="count", help="Enable verbose logging")
     arg_parser.add_argument("api_version", metavar="API_VERSION", help="API Version to check")
     args = arg_parser.parse_args()

buildscripts/idl/checkout_idl_files_from_past_releases.py

@@ -41,20 +41,24 @@
     sys.path.append(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))))
 
 # pylint: disable=wrong-import-position
-from buildscripts.resmokelib.multiversionconstants import LAST_LTS_FCV, LAST_CONTINUOUS_FCV, LATEST_FCV
+from buildscripts.resmokelib.multiversionconstants import (
+    LAST_LTS_FCV,
+    LAST_CONTINUOUS_FCV,
+    LATEST_FCV,
+)
 # pylint: enable=wrong-import-position
 
-LOGGER_NAME = 'checkout-idl'
+LOGGER_NAME = "checkout-idl"
 LOGGER = logging.getLogger(LOGGER_NAME)
 
 
 def get_tags() -> List[str]:
     """Get a list of git tags that the IDL compatibility script should check against."""
 
     def gen_versions_and_tags():
-        for tag in check_output(['git', 'tag']).decode().split():
+        for tag in check_output(["git", "tag"]).decode().split():
             # Releases are like "r5.6.7". Older ones aren't r-prefixed but we don't care about them.
-            if not tag.startswith('r'):
+            if not tag.startswith("r"):
                 continue
 
             try:
@@ -110,23 +114,24 @@ def make_idl_directories(tags: List[str], destination: str) -> None:
     for tag in tags:
         LOGGER.info("Checking out IDL files in %s", tag)
         directory = os.path.join(destination, tag)
-        for path in check_output(['git', 'ls-tree', '--name-only', '-r', tag]).decode().split():
-            if not path.endswith('.idl'):
+        for path in check_output(["git", "ls-tree", "--name-only", "-r", tag]).decode().split():
+            if not path.endswith(".idl"):
                 continue
 
-            contents = check_output(['git', 'show', f'{tag}:{path}']).decode()
+            contents = check_output(["git", "show", f"{tag}:{path}"]).decode()
             output_path = os.path.join(directory, path)
             os.makedirs(os.path.dirname(output_path), exist_ok=True)
-            with open(output_path, 'w+') as fd:
+            with open(output_path, "w+") as fd:
                 fd.write(contents)
 
 
 def main():
     """Run the script."""
     arg_parser = argparse.ArgumentParser(description=__doc__)
     arg_parser.add_argument("-v", "--verbose", action="count", help="Enable verbose logging")
-    arg_parser.add_argument("destination", metavar="DESTINATION",
-                            help="Directory to check out past IDL file versions")
+    arg_parser.add_argument(
+        "destination", metavar="DESTINATION", help="Directory to check out past IDL file versions"
+    )
     args = arg_parser.parse_args()
 
     logging.basicConfig(level=logging.WARNING)

buildscripts/idl/gen_all_feature_flag_list.py

@@ -38,7 +38,7 @@
 import yaml
 
 # Permit imports from "buildscripts".
-sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), '../../..')))
+sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), "../../..")))
 
 # pylint: disable=wrong-import-position
 from buildscripts.idl import lib
@@ -60,7 +60,7 @@ def get_all_feature_flags(idl_dirs: List[str] = None):
             # Most IDL files do not contain feature flags.
             # We can discard these quickly without expensive YAML parsing.
             with open(idl_path) as idl_file:
-                if 'feature_flags' not in idl_file.read():
+                if "feature_flags" not in idl_file.read():
                     continue
             with open(idl_path) as idl_file:
                 doc = parser.parse_file(idl_file, idl_path)
@@ -100,5 +100,5 @@ def main():
     gen_all_feature_flags_file()
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()

buildscripts/idl/gen_all_server_params_list.py

@@ -36,7 +36,7 @@
 from typing import List
 
 # Permit imports from "buildscripts".
-sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), '../../..')))
+sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), "../../..")))
 
 # pylint: disable=wrong-import-position
 from buildscripts.idl import lib
@@ -58,7 +58,7 @@ def gen_all_server_params(idl_dirs: List[str] = None):
             # Most IDL files do not contain server parameters.
             # We can discard these quickly without expensive YAML parsing.
             with open(idl_path) as idl_file:
-                if 'server_parameters' not in idl_file.read():
+                if "server_parameters" not in idl_file.read():
                     continue
             with open(idl_path) as idl_file:
                 doc = parser.parse_file(idl_file, idl_path)
@@ -80,5 +80,5 @@ def main():
     gen_all_server_params_file()
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()

buildscripts/idl/idl/ast.py

@@ -33,6 +33,7 @@
 This is a lossy translation from the IDL Syntax tree as the IDL AST only contains information about
 the enums and structs that need code generated for them, and just enough information to do that.
 """
+
 from abc import ABCMeta, abstractmethod
 import enum
 from typing import Any, Dict, List, Optional
@@ -46,8 +47,9 @@ class IDLBoundSpec(object):
     def __init__(self, spec, error_collection):
         # type: (IDLAST, errors.ParserErrorCollection) -> None
         """Must specify either an IDL document or errors, not both."""
-        assert (spec is None and error_collection is not None) or (spec is not None
-                                                                   and error_collection is None)
+        assert (spec is None and error_collection is not None) or (
+            spec is not None and error_collection is None
+        )
         self.spec = spec
         self.errors = error_collection
 
@@ -292,7 +294,8 @@ def should_serialize_with_options(self):
         # type: () -> bool
         """Returns true if the IDL compiler should add a call to serialization options for this field."""
         return self.query_shape is not None and self.query_shape in [
-            QueryShapeFieldType.LITERAL, QueryShapeFieldType.ANONYMIZE
+            QueryShapeFieldType.LITERAL,
+            QueryShapeFieldType.ANONYMIZE,
         ]
 
     @property