Skip to content

Commit 99802be

Browse files
committed
Address review
1 parent ed3dea5 commit 99802be

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

test/asynchronous/test_client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,8 @@ async def test_init_disconnected_with_auth(self):
849849
with self.assertRaises(ConnectionFailure):
850850
await c.pymongo_test.test.find_one()
851851

852-
@async_client_context.require_replica_set
852+
@async_client_context.require_no_standalone
853+
@async_client_context.require_no_load_balancer
853854
@async_client_context.require_tls
854855
async def test_init_disconnected_with_srv(self):
855856
c = await self.async_rs_or_single_client(
@@ -875,20 +876,23 @@ async def test_init_disconnected_with_srv(self):
875876
self.assertEqual(
876877
c._topology._topology_id, topology_description._topology_settings._topology_id
877878
)
879+
await c.close()
878880

879881
c = await self.async_rs_or_single_client(
880882
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True
881883
)
882884
# primary causes client to block until connected
883885
await c.primary
884886
self.assertIsNotNone(c._topology)
887+
await c.close()
885888

886889
c = await self.async_rs_or_single_client(
887890
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True
888891
)
889892
# secondaries causes client to block until connected
890893
await c.secondaries
891894
self.assertIsNotNone(c._topology)
895+
await c.close()
892896

893897
c = await self.async_rs_or_single_client(
894898
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True

test/test_client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,8 @@ def test_init_disconnected_with_auth(self):
824824
with self.assertRaises(ConnectionFailure):
825825
c.pymongo_test.test.find_one()
826826

827-
@client_context.require_replica_set
827+
@client_context.require_no_standalone
828+
@client_context.require_no_load_balancer
828829
@client_context.require_tls
829830
def test_init_disconnected_with_srv(self):
830831
c = self.rs_or_single_client(
@@ -850,20 +851,23 @@ def test_init_disconnected_with_srv(self):
850851
self.assertEqual(
851852
c._topology._topology_id, topology_description._topology_settings._topology_id
852853
)
854+
c.close()
853855

854856
c = self.rs_or_single_client(
855857
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True
856858
)
857859
# primary causes client to block until connected
858860
c.primary
859861
self.assertIsNotNone(c._topology)
862+
c.close()
860863

861864
c = self.rs_or_single_client(
862865
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True
863866
)
864867
# secondaries causes client to block until connected
865868
c.secondaries
866869
self.assertIsNotNone(c._topology)
870+
c.close()
867871

868872
c = self.rs_or_single_client(
869873
"mongodb+srv://test1.test.build.10gen.cc", connect=False, tlsInsecure=True

0 commit comments

Comments
 (0)