Skip to content

Commit ea2bb11

Browse files
authored
Tidy up BULK-TODOs (#1599)
JAVA-4586
1 parent 6e2ce8c commit ea2bb11

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

driver-scala/src/integration/scala/org/mongodb/scala/syncadapter/SyncMongoCluster.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,32 +130,32 @@ class SyncMongoCluster(wrapped: MongoCluster) extends JMongoCluster {
130130
override def bulkWrite(
131131
models: util.List[_ <: ClientNamespacedWriteModel]
132132
): ClientBulkWriteResult = {
133-
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
134-
throw Assertions.fail("BULK-TODO implement")
133+
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
134+
throw Assertions.fail("TODO-JAVA-5531 implement")
135135
}
136136

137137
override def bulkWrite(
138138
models: util.List[_ <: ClientNamespacedWriteModel],
139139
options: ClientBulkWriteOptions
140140
): ClientBulkWriteResult = {
141-
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
142-
throw Assertions.fail("BULK-TODO implement")
141+
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
142+
throw Assertions.fail("TODO-JAVA-5531 implement")
143143
}
144144

145145
override def bulkWrite(
146146
clientSession: ClientSession,
147147
models: util.List[_ <: ClientNamespacedWriteModel]
148148
): ClientBulkWriteResult = {
149-
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
150-
throw Assertions.fail("BULK-TODO implement")
149+
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
150+
throw Assertions.fail("TODO-JAVA-5531 implement")
151151
}
152152

153153
override def bulkWrite(
154154
clientSession: ClientSession,
155155
models: util.List[_ <: ClientNamespacedWriteModel],
156156
options: ClientBulkWriteOptions
157157
): ClientBulkWriteResult = {
158-
org.junit.Assume.assumeTrue("BULK-TODO implement", java.lang.Boolean.parseBoolean(toString))
159-
throw Assertions.fail("BULK-TODO implement")
158+
org.junit.Assume.assumeTrue("TODO-JAVA-5531 implement", java.lang.Boolean.parseBoolean(toString))
159+
throw Assertions.fail("TODO-JAVA-5531 implement")
160160
}
161161
}

driver-scala/src/test/scala/org/mongodb/scala/ApiAliasAndCompanionSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class ApiAliasAndCompanionSpec extends BaseSpec {
154154
.map(_.getSimpleName)
155155
.toSet +
156156
"MongoException" - "MongoGridFSException" - "MongoConfigurationException" - "MongoWriteConcernWithResponseException" -
157-
// BULK-TODO remove this exclusion
157+
// TODO-JAVA-5531 remove the `"ClientBulkWriteException"` exclusion
158158
"ClientBulkWriteException"
159159

160160
val objects = new Reflections(

driver-scala/src/test/scala/org/mongodb/scala/MongoClientSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ class MongoClientSpec extends BaseSpec with MockitoSugar {
3636
wrapped.foreach((name: String) => {
3737
val cleanedName = name.stripPrefix("get")
3838

39-
// TODO("BULK-TODO remove this if when bulkWrite is implemented and uncomment line 43")
4039
if (!cleanedName.contains("bulkWrite")) {
40+
// TODO-JAVA-5531 remove this whole `if` block
4141
assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
4242
}
43-
// assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
43+
// TODO-JAVA-5531 uncomment: assert(local.contains(name) | local.contains(cleanedName.head.toLower + cleanedName.tail), s"Missing: $name")
4444
})
4545
}
4646

0 commit comments

Comments
 (0)