Skip to content

Commit e470e03

Browse files
improves PojoCodecDiscriminatorTest by replacing the encodesTo test with the roundTrip one
1 parent f7b0ddc commit e470e03

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

bson/src/test/unit/org/bson/codecs/pojo/PojoCodecDiscriminatorTest.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,8 @@ public void testDiscriminatorEncodedOnceWhenItIsAlsoAGetter() {
4040
}
4141

4242
@Test
43-
public void testDiscriminatorEncodingWhenItIsAlsoAGetter() {
44-
encodesTo(
45-
getCodec(DiscriminatorWithGetterModel.class),
43+
public void testDiscriminatorRoundTripWhenItIsAlsoAGetter() {
44+
roundTrip(
4645
new DiscriminatorWithGetterModel(),
4746
"{discriminatorKey:'discriminatorValue'}"
4847
);

bson/src/test/unit/org/bson/codecs/pojo/entities/DiscriminatorModel.java

-5
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,4 @@ public class DiscriminatorModel {
2323

2424
public DiscriminatorModel() {
2525
}
26-
27-
@Override
28-
public String toString() {
29-
return "DiscriminatorWithoutGetterModel{}";
30-
}
3126
}

bson/src/test/unit/org/bson/codecs/pojo/entities/DiscriminatorWithGetterModel.java

+14
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
import org.bson.codecs.pojo.annotations.BsonDiscriminator;
2020

21+
import java.util.Objects;
22+
2123
@BsonDiscriminator(key = "discriminatorKey", value = "discriminatorValue")
2224
public class DiscriminatorWithGetterModel {
2325

@@ -28,6 +30,18 @@ public String getDiscriminatorKey() {
2830
return "discriminatorValue";
2931
}
3032

33+
@Override
34+
public boolean equals(final Object o) {
35+
if (o == null || getClass() != o.getClass()) return false;
36+
final DiscriminatorWithGetterModel that = (DiscriminatorWithGetterModel) o;
37+
return Objects.equals(getDiscriminatorKey(), that.getDiscriminatorKey());
38+
}
39+
40+
@Override
41+
public int hashCode() {
42+
return Objects.hashCode(getDiscriminatorKey());
43+
}
44+
3145
@Override
3246
public String toString() {
3347
return "DiscriminatorWithGetterModel{}";

0 commit comments

Comments
 (0)