Skip to content

Commit b9cd758

Browse files
katcharovstIncMale
andcommitted
Apply suggestions from code review
Co-authored-by: Valentin Kovalenko <[email protected]>
1 parent 771ea89 commit b9cd758

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,19 @@
2222
import java.util.concurrent.ExecutorService;
2323

2424
/**
25-
* {@link TransportSettings} for an async transport implementation.
25+
* {@link TransportSettings} for a non-<a href="http://netty.io/">Netty</a>-based async transport implementation.
2626
*
2727
* @since 5.2
2828
*/
29-
public class AsyncTransportSettings extends TransportSettings {
29+
public final class AsyncTransportSettings extends TransportSettings {
3030

3131
private final ExecutorService executorService;
3232

33-
public AsyncTransportSettings(final Builder builder) {
33+
private AsyncTransportSettings(final Builder builder) {
3434
this.executorService = builder.executorService;
3535
}
3636

37-
public static Builder builder() {
37+
static Builder builder() {
3838
return new Builder();
3939
}
4040

@@ -54,6 +54,7 @@ private Builder() {
5454
* @param executorService the executor service
5555
* @return this
5656
* @see #getExecutorService()
57+
* @see AsynchronousChannelGroup#withThreadPool(ExecutorService)
5758
*/
5859
public Builder executorService(final ExecutorService executorService) {
5960
this.executorService = executorService;

driver-core/src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStreamFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public AsynchronousSocketChannelStreamFactory(
4949
this(inetAddressResolver, settings, sslSettings, null);
5050
}
5151

52-
public AsynchronousSocketChannelStreamFactory(
52+
AsynchronousSocketChannelStreamFactory(
5353
final InetAddressResolver inetAddressResolver, final SocketSettings settings,
5454
final SslSettings sslSettings, @Nullable final ExecutorService executorService) {
5555
assertFalse(sslSettings.isEnabled());

driver-core/src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStreamFactoryFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public AsynchronousSocketChannelStreamFactoryFactory(final InetAddressResolver i
3737
this(inetAddressResolver, null);
3838
}
3939

40-
public AsynchronousSocketChannelStreamFactoryFactory(
40+
AsynchronousSocketChannelStreamFactoryFactory(
4141
final InetAddressResolver inetAddressResolver,
4242
@Nullable final ExecutorService executorService) {
4343
this.inetAddressResolver = inetAddressResolver;

driver-core/src/main/com/mongodb/internal/connection/TlsChannelStreamFactoryFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public class TlsChannelStreamFactoryFactory implements StreamFactoryFactory {
7272
/**
7373
* Construct a new instance
7474
*/
75-
public TlsChannelStreamFactoryFactory(final InetAddressResolver inetAddressResolver,
75+
TlsChannelStreamFactoryFactory(final InetAddressResolver inetAddressResolver,
7676
@Nullable final ExecutorService executorService) {
7777
this.inetAddressResolver = inetAddressResolver;
7878
this.group = new AsynchronousTlsChannelGroup(executorService);

0 commit comments

Comments
 (0)