Improve performance of MongoNamespace.checkDatabaseNameValidity

jstewart148 · jstewart148 · commit 0c008785a3f7 · 2020-02-21T10:22:26.000-05:00
JAVA-3619
diff --git a/driver-core/src/main/com/mongodb/MongoNamespace.java b/driver-core/src/main/com/mongodb/MongoNamespace.java
@@ -58,8 +58,9 @@ public static void checkDatabaseNameValidity(final String databaseName) {
         notNull("databaseName", databaseName);
         isTrueArgument("databaseName is not empty", !databaseName.isEmpty());
         for (int i = 0; i < databaseName.length(); i++) {
-            isTrueArgument("databaseName does not contain '" + databaseName.charAt(i) + "'",
-                    !PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i)));
+            if (PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i))) {
+                throw new IllegalArgumentException("state should be: databaseName does not contain '" + databaseName.charAt(i) + "'");
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,9 @@ public static void checkDatabaseNameValidity(final String databaseName) {`
`58`	`58`	`notNull("databaseName", databaseName);`
`59`	`59`	`isTrueArgument("databaseName is not empty", !databaseName.isEmpty());`
`60`	`60`	`for (int i = 0; i < databaseName.length(); i++) {`
`61`		`- isTrueArgument("databaseName does not contain '" + databaseName.charAt(i) + "'",`
`62`		`- !PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i)));`
	`61`	`+ if (PROHIBITED_CHARACTERS_IN_DATABASE_NAME.contains(databaseName.charAt(i))) {`
	`62`	`+ throw new IllegalArgumentException("state should be: databaseName does not contain '" + databaseName.charAt(i) + "'");`
	`63`	`+ }`
`63`	`64`	`}`
`64`	`65`	`}`
`65`	`66`