moving gd[].dimensions out of parcoords.js plotly#3

Author: monfera

src/traces/parcoords/parcoords.js

@@ -508,26 +508,8 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
                 p.pickLineLayer && p.pickLineLayer.render(p.panels, true);
                 linePickActive = true;
 
-                function newIdx(orig, dim) {
-                    var origIndex = orig.indexOf(dim);
-                    var currentIndex = p.dimensions.map(function(dd) {return dd.crossfilterDimensionIndex;}).indexOf(origIndex);
-                    if(currentIndex === -1) {
-                        // invisible dimensions go to the end, retaining their original order
-                        currentIndex += orig.length;
-                    }
-                    return currentIndex;
-                }
-
-                function sorter(orig) {
-                    return function sorter(d1, d2) {
-                        var i1 = newIdx(orig, d1);
-                        var i2 = newIdx(orig, d2);
-                        return i1 - i2;
-                    };
-                }
-
                 if(callbacks && callbacks.axesMoved) {
-                    callbacks.axesMoved(p.key, sorter);
+                    callbacks.axesMoved(p.key, p.dimensions.map(function(dd) {return dd.crossfilterDimensionIndex;}));
                 }
             })
         );

src/traces/parcoords/plot.js

@@ -50,11 +50,29 @@ module.exports = function plot(gd, cdparcoords) {
         gd.emit('plotly_unhover', eventData);
     };
 
-    var axesMoved = function(i, sorter) {
+    var axesMoved = function(i, visibleIndices) {
 
         // Have updated order data on `gd.data` and raise `Plotly.restyle` event
         // without having to incur heavy UI blocking due to an actual `Plotly.restyle` call
 
+        function newIdx(visibleIndices, orig, dim) {
+            var origIndex = orig.indexOf(dim);
+            var currentIndex = visibleIndices.indexOf(origIndex);
+            if(currentIndex === -1) {
+                // invisible dimensions go to the end, retaining their original order
+                currentIndex += orig.length;
+            }
+            return currentIndex;
+        }
+
+        function sorter(orig) {
+            return function sorter(d1, d2) {
+                var i1 = newIdx(visibleIndices, orig, d1);
+                var i2 = newIdx(visibleIndices, orig, d2);
+                return i1 - i2;
+            };
+        }
+
         var orig = sorter(gdDimensionsOriginalOrder[i].filter(function(d) {return d.visible === void(0) || d.visible;}));
         gdDimensions[i].sort(orig);