plotly#189 PR feedback

Author: monfera

src/plots/gl3d/layout/axis_attributes.js

@@ -68,35 +68,8 @@ module.exports = {
         description: 'Sets whether or not this axis is labeled'
     },
     color: axesAttrs.color,
-    categorymode: {
-        valType: 'enumerated',
-        values: [
-            'trace', 'category ascending', 'category descending', 'array'
-            /*, 'value ascending', 'value descending'*/ // value ascending / descending to be implemented later
-        ],
-        dflt: 'trace',
-        role: 'info',
-        description: [
-            'Specifies the ordering logic for the case of categorical variables.',
-            'By default, plotly uses *trace*, which specifies the order that is present in the data supplied.',
-            'Set `categorymode` to *category ascending* or *category descending* if order should be determined by',
-            'the alphanumerical order of the category names.',
-            /*'Set `categorymode` to *value ascending* or *value descending* if order should be determined by the',
-             'numerical order of the values.',*/ // // value ascending / descending to be implemented later
-            'Set `categorymode` to *array* to derive the ordering from the attribute `categorylist`. If a category',
-            'is not found in the `categorylist` array, the sorting behavior for that attribute will be identical to',
-            'the *trace* mode. The unspecified categories will follow the categories in `categorylist`.'
-        ].join(' ')
-    },
-    categorylist: {
-        valType: 'data_array',
-        role: 'info',
-        description: [
-            'Sets the order in which categories on this axis appear.',
-            'Only has an effect if `categorymode` is set to *array*.',
-            'Used with `categorymode`.'
-        ].join(' ')
-    },
+    categorymode: axesAttrs.categorymode,
+    categorylist: axesAttrs.categorylist,
     title: axesAttrs.title,
     titlefont: axesAttrs.titlefont,
     type: axesAttrs.type,

test/jasmine/tests/calcdata_test.js

@@ -139,53 +139,6 @@ describe('calculated data and points', function() {
             });
         });
 
-/*
-        describe('codomain numerical category ordering', function() {
-
-            it('should output categories in ascending codomain numerical order', function() {
-
-                Plotly.plot(gd, [{x: ['c','a','e','b','d'], y: [15,11,12,13,14]}], { xaxis: {
-                    type: 'category',
-                    categorymode: 'value ascending'
-                }});
-
-                expect(gd.calcdata[0][0].y).toEqual(11);
-                expect(gd.calcdata[0][1].y).toEqual(12);
-                expect(gd.calcdata[0][2].y).toEqual(13);
-                expect(gd.calcdata[0][3].y).toEqual(14);
-                expect(gd.calcdata[0][4].y).toEqual(15);
-            });
-
-            it('should output categories in descending codomain numerical order', function() {
-
-                Plotly.plot(gd, [{x: ['c','a','e','b','d'], y: [15,11,12,13,14]}], { xaxis: {
-                    type: 'category',
-                    categorymode: 'value descending'
-                }});
-
-                expect(gd.calcdata[0][0].y).toEqual(15);
-                expect(gd.calcdata[0][1].y).toEqual(14);
-                expect(gd.calcdata[0][2].y).toEqual(13);
-                expect(gd.calcdata[0][3].y).toEqual(12);
-                expect(gd.calcdata[0][4].y).toEqual(11);
-            });
-
-            it('should output categories in descending codomain numerical order, excluding nulls', function() {
-
-                Plotly.plot(gd, [{x: ['c','a','e','b','d'], y: [15,11,null,13,14]}], { xaxis: {
-                    type: 'category',
-                    categorymode: 'value descending'
-                }});
-
-                expect(gd.calcdata[0][0].y).toEqual(15);
-                expect(gd.calcdata[0][1].y).toEqual(14);
-                expect(gd.calcdata[0][2].y).toEqual(12);
-                expect(gd.calcdata[0][3].y).toEqual(11);
-
-            });
-        });
-*/
-
         describe('explicit category ordering', function() {
 
             it('should output categories in explicitly supplied order, independent of trace order', function() {