From d01ba4603b950786694a689f2f5bd9e8615a801d Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri Date: Tue, 2 Jul 2024 17:51:35 +0000 Subject: [PATCH 1/6] Add pull_requests file --- .github/pull_requests.toml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .github/pull_requests.toml diff --git a/.github/pull_requests.toml b/.github/pull_requests.toml new file mode 100644 index 0000000000000..f8a64a981b1e8 --- /dev/null +++ b/.github/pull_requests.toml @@ -0,0 +1,3 @@ +[committee] +members = [ +] From e50a55e259ed95ffe72fb469fa718ceecd7b3f1e Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri Date: Tue, 2 Jul 2024 17:55:32 +0000 Subject: [PATCH 2/6] Add committee application guidelines --- doc/src/general-rules.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/src/general-rules.md b/doc/src/general-rules.md index 083227009d934..8efb285b8c2cc 100644 --- a/doc/src/general-rules.md +++ b/doc/src/general-rules.md @@ -81,3 +81,15 @@ Solutions must be automated using one of the tools previously approved and liste I.e., the action may no longer pass after an update. This will not impact the approval status of the tool, however, new solutions that want to employ the tool may need to ensure the action is passing first. + +## Committee Applications + +You can apply to be part of the committee by submitting a pull request that adds your github login name to the pull_request.toml file. + +For example, add @rahulku without @ to the committee member's list, +``` +[committee] +members = [ ++ "rahulku" +] +``` From 5b6e26ab49835440f0221bc00988621fc71986b0 Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri Date: Tue, 2 Jul 2024 17:56:52 +0000 Subject: [PATCH 3/6] Fix grammer --- doc/src/general-rules.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/general-rules.md b/doc/src/general-rules.md index 8efb285b8c2cc..bbe05c3c648a2 100644 --- a/doc/src/general-rules.md +++ b/doc/src/general-rules.md @@ -86,7 +86,7 @@ Solutions must be automated using one of the tools previously approved and liste You can apply to be part of the committee by submitting a pull request that adds your github login name to the pull_request.toml file. -For example, add @rahulku without @ to the committee member's list, +For example, if your user login is @rahulku, add the login without @ to the committee member's list, ``` [committee] members = [ From 94b302ad4b87d3c23c289bb2379289192551423a Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri Date: Tue, 2 Jul 2024 19:41:13 +0000 Subject: [PATCH 4/6] Add initial committee to start --- .github/pull_requests.toml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/pull_requests.toml b/.github/pull_requests.toml index f8a64a981b1e8..16894b02744d8 100644 --- a/.github/pull_requests.toml +++ b/.github/pull_requests.toml @@ -1,3 +1,13 @@ [committee] members = [ + "celinval", + "rahulku", + "pnkfelix", + "adpaco-aws", + "feliperodri", + "zhassan-aws", + "remi-delmas-3000", + "qinheping", + "tautschnig" + "jaisnan" ] From 6957f680095b2d9e5005e3d0ee6ef30c2376b882 Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri Date: Tue, 2 Jul 2024 19:42:44 +0000 Subject: [PATCH 5/6] Fix formatting --- .github/pull_requests.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_requests.toml b/.github/pull_requests.toml index 16894b02744d8..12113728fc722 100644 --- a/.github/pull_requests.toml +++ b/.github/pull_requests.toml @@ -8,6 +8,6 @@ members = [ "zhassan-aws", "remi-delmas-3000", "qinheping", - "tautschnig" + "tautschnig", "jaisnan" ] From 0a5c2f885b3c47dfe197df065535072ad4b168aa Mon Sep 17 00:00:00 2001 From: Jaisurya Nanduri <91620234+jaisnan@users.noreply.github.com> Date: Wed, 3 Jul 2024 12:00:12 -0400 Subject: [PATCH 6/6] Apply suggestions from code review Co-authored-by: Felipe R. Monteiro --- doc/src/general-rules.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/general-rules.md b/doc/src/general-rules.md index bbe05c3c648a2..c681e9bb8953d 100644 --- a/doc/src/general-rules.md +++ b/doc/src/general-rules.md @@ -84,7 +84,7 @@ Solutions must be automated using one of the tools previously approved and liste ## Committee Applications -You can apply to be part of the committee by submitting a pull request that adds your github login name to the pull_request.toml file. +You can apply to be part of the committee by submitting a pull request that adds your GitHub login name to the `pull_request.toml` file. For example, if your user login is @rahulku, add the login without @ to the committee member's list, ```