Skip to content

Commit adbc84c

Browse files
committed
Remove redundant success expressions from steps
1 parent 24bf359 commit adbc84c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
run: echo "[CI_PR_NUMBER=$num]"
117117
env:
118118
num: ${{ github.event.number }}
119-
if: success() && github.event_name == 'pull_request'
119+
if: github.event_name == 'pull_request'
120120

121121
- name: add extra environment variables
122122
run: src/ci/scripts/setup-environment.sh
@@ -219,7 +219,7 @@ jobs:
219219
# adding the condition is helpful as this way CI will not silently skip
220220
# deploying artifacts from a dist builder if the variables are misconfigured,
221221
# erroring about invalid credentials instead.
222-
if: success() && (github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1')
222+
if: github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1'
223223

224224
# This job isused to tell bors the final status of the build, as there is no practical way to detect
225225
# when a workflow is successful listening to webhooks only in our current bors implementation (homu).

0 commit comments

Comments
 (0)