Skip to content

Commit 15a8e65

Browse files
Add review guidelines (#226)
Extends committee membership information with guidance on what is expected of committee members. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Carolyn Zech <[email protected]>
1 parent 955577c commit 15a8e65

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

doc/src/general-rules.md

+18
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,21 @@ members = [
9292
+ "rahulku"
9393
]
9494
```
95+
96+
Committee members are expected to contribute by reviewing pull requests (all
97+
pull requests review approvals from at least two committee members before they
98+
can be merged).
99+
Reviews of solutions towards challenges should consider at least the following aspects:
100+
101+
1. Does the pull request implement a solution that respects/meets the success
102+
criteria of the challenge?
103+
2. Do the contracts and harnesses incorporate the safety conditions stated in
104+
the documentation (from comments in the code and the
105+
[standard library documentation](https://doc.rust-lang.org/std/index.html))?
106+
Note that we currently focus on safety verification. Pre- and post-conditions
107+
towards functional correctness are acceptable as long as they do not
108+
negatively impact verification of safety, such as over-constraining input
109+
values or causing excessive verification run time.
110+
3. Is the contributed code of adequate quality, idiomatic, and stands a chance
111+
to be accepted into the standard library (to the best of the committee
112+
member's knowledge)?

0 commit comments

Comments
 (0)