Skip to content

Commit 0f9844d

Browse files
committed
Temporarily disable M1 runners on GitHub Actions
This commit temporarily reverts the addition of M1 runners on GitHub Actions to work around a billing issue related to their beta. It also removes the `aarch64-apple` job, which was only added after the addition of M1 runners. Since it has never been tested on the prior hardware, we are skipping the tests to reduce the risk of build failures.
1 parent e51e98d commit 0f9844d

File tree

2 files changed

+18
-38
lines changed

2 files changed

+18
-38
lines changed

.github/workflows/ci.yml

+4-16
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,8 @@ jobs:
361361
os: macos-13
362362
- name: dist-aarch64-apple
363363
env:
364-
SCRIPT: "./x.py dist bootstrap --include-default-paths --host=aarch64-apple-darwin --target=aarch64-apple-darwin"
365-
RUST_CONFIGURE_ARGS: "--enable-full-tools --enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false --set rust.lto=thin"
364+
SCRIPT: "./x.py dist bootstrap --include-default-paths --stage 2"
365+
RUST_CONFIGURE_ARGS: "--build=x86_64-apple-darwin --host=aarch64-apple-darwin --target=aarch64-apple-darwin --enable-full-tools --enable-sanitizers --enable-profiler --disable-docs --set rust.jemalloc --set llvm.ninja=false"
366366
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
367367
SELECT_XCODE: /Applications/Xcode_13.4.1.app
368368
USE_XCODE_CLANG: 1
@@ -372,20 +372,8 @@ jobs:
372372
NO_DEBUG_ASSERTIONS: 1
373373
NO_OVERFLOW_CHECKS: 1
374374
DIST_REQUIRE_ALL_TOOLS: 1
375-
os: macos-13-xlarge
376-
- name: aarch64-apple
377-
env:
378-
SCRIPT: "./x.py --stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin"
379-
RUST_CONFIGURE_ARGS: "--enable-sanitizers --enable-profiler --set rust.jemalloc --set llvm.ninja=false"
380-
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
381-
SELECT_XCODE: /Applications/Xcode_13.4.1.app
382-
USE_XCODE_CLANG: 1
383-
MACOSX_DEPLOYMENT_TARGET: 11.0
384-
MACOSX_STD_DEPLOYMENT_TARGET: 11.0
385-
NO_LLVM_ASSERTIONS: 1
386-
NO_DEBUG_ASSERTIONS: 1
387-
NO_OVERFLOW_CHECKS: 1
388-
os: macos-13-xlarge
375+
JEMALLOC_SYS_WITH_LG_PAGE: 14
376+
os: macos-13
389377
- name: x86_64-msvc
390378
env:
391379
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-profiler"

src/ci/github-actions/ci.yml

+14-22
Original file line numberDiff line numberDiff line change
@@ -553,14 +553,17 @@ jobs:
553553
# This target only needs to support 11.0 and up as nothing else supports the hardware
554554
- name: dist-aarch64-apple
555555
env:
556-
SCRIPT: ./x.py dist bootstrap --include-default-paths --host=aarch64-apple-darwin --target=aarch64-apple-darwin
556+
SCRIPT: ./x.py dist bootstrap --include-default-paths --stage 2
557557
RUST_CONFIGURE_ARGS: >-
558+
--build=x86_64-apple-darwin
559+
--host=aarch64-apple-darwin
560+
--target=aarch64-apple-darwin
558561
--enable-full-tools
559562
--enable-sanitizers
560563
--enable-profiler
564+
--disable-docs
561565
--set rust.jemalloc
562566
--set llvm.ninja=false
563-
--set rust.lto=thin
564567
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
565568
SELECT_XCODE: /Applications/Xcode_13.4.1.app
566569
USE_XCODE_CLANG: 1
@@ -570,26 +573,15 @@ jobs:
570573
NO_DEBUG_ASSERTIONS: 1
571574
NO_OVERFLOW_CHECKS: 1
572575
DIST_REQUIRE_ALL_TOOLS: 1
573-
<<: *job-macos-m1
574-
575-
# This target only needs to support 11.0 and up as nothing else supports the hardware
576-
- name: aarch64-apple
577-
env:
578-
SCRIPT: ./x.py --stage 2 test --host=aarch64-apple-darwin --target=aarch64-apple-darwin
579-
RUST_CONFIGURE_ARGS: >-
580-
--enable-sanitizers
581-
--enable-profiler
582-
--set rust.jemalloc
583-
--set llvm.ninja=false
584-
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
585-
SELECT_XCODE: /Applications/Xcode_13.4.1.app
586-
USE_XCODE_CLANG: 1
587-
MACOSX_DEPLOYMENT_TARGET: 11.0
588-
MACOSX_STD_DEPLOYMENT_TARGET: 11.0
589-
NO_LLVM_ASSERTIONS: 1
590-
NO_DEBUG_ASSERTIONS: 1
591-
NO_OVERFLOW_CHECKS: 1
592-
<<: *job-macos-m1
576+
# Corresponds to 16K page size
577+
#
578+
# Shouldn't be needed if jemalloc-sys is updated to
579+
# handle this platform like iOS or if we build on
580+
# aarch64-apple-darwin itself.
581+
#
582+
# https://github.com/gnzlbg/jemallocator/blob/c27a859e98e3cb790dc269773d9da71a1e918458/jemalloc-sys/build.rs#L237
583+
JEMALLOC_SYS_WITH_LG_PAGE: 14
584+
<<: *job-macos-xl
593585

594586
######################
595587
# Windows Builders #

0 commit comments

Comments
 (0)