Skip to content

Commit edeb6ba

Browse files
committed
golangci-lint: temporarily disable G115: integer overflow conversion
it produces many hits, some of which may be false positives, but we need to look into these, e.g.; container/container.go:517:72: G115: integer overflow conversion int -> uint32 (gosec) shouldRestart, _, _ := container.RestartManager().ShouldRestart(uint32(container.ExitCode()), container.HasBeenManuallyStopped, container.FinishedAt.Sub(container.StartedAt)) ^ container/view.go:401:25: G115: integer overflow conversion int -> uint16 (gosec) PrivatePort: uint16(p), ^ container/view.go:413:25: G115: integer overflow conversion int -> uint16 (gosec) PrivatePort: uint16(p), ^ container/view.go:414:25: G115: integer overflow conversion int -> uint16 (gosec) PublicPort: uint16(h), ^ Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit f5108e9) Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent adb0b85 commit edeb6ba

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.golangci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ linters-settings:
4545

4646
govet:
4747
check-shadowing: false
48+
49+
gosec:
50+
excludes:
51+
- G115 # FIXME temporarily suppress 'G115: integer overflow conversion': it produces many hits, some of which may be false positives, and need to be looked at; see https://github.com/moby/moby/issues/48358
52+
4853
depguard:
4954
rules:
5055
main:

0 commit comments

Comments
 (0)