Skip to content

Commit 710c74e

Browse files
yl-tomufiAmazon
authored andcommitted
fix: remove debugger environment var set up (aws#3431)
1 parent d402aff commit 710c74e

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

src/sagemaker/estimator.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -865,10 +865,6 @@ def _prepare_debugger_for_training(self):
865865
self.debugger_rule_configs = self._prepare_debugger_rules()
866866
self._prepare_collection_configs()
867867
self._validate_and_set_debugger_configs()
868-
if not self.debugger_hook_config:
869-
if self.environment is None:
870-
self.environment = {}
871-
self.environment[DEBUGGER_FLAG] = "0"
872868

873869
def _validate_and_set_debugger_configs(self):
874870
"""Set defaults for debugging."""

tests/integ/test_debugger.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import pytest
1919

2020
from sagemaker.debugger.debugger import (
21-
DEBUGGER_FLAG,
2221
DebuggerHookConfig,
2322
Rule,
2423
rule_configs,
@@ -749,7 +748,6 @@ def test_mxnet_with_debugger_hook_config_disabled(
749748
job_description = mx.latest_training_job.describe()
750749

751750
assert job_description.get("DebugHookConfig") is None
752-
assert job_description.get("Environment", {}).get(DEBUGGER_FLAG) == "0"
753751

754752

755753
def _get_rule_evaluation_statuses(job_description):

tests/unit/sagemaker/tensorflow/test_estimator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ def test_fit_ps(time, strftime, sagemaker_session):
483483
expected_train_args = _create_train_job("1.11", ps=True, py_version="py2")
484484
expected_train_args["input_config"][0]["DataSource"]["S3DataSource"]["S3Uri"] = inputs
485485
expected_train_args["hyperparameters"][TensorFlow.LAUNCH_PS_ENV_NAME] = json.dumps(True)
486-
expected_train_args["environment"] = {"USE_SMDEBUG": "0"}
487486

488487
actual_train_args = sagemaker_session.method_calls[0][2]
489488
assert actual_train_args == expected_train_args

tests/unit/sagemaker/workflow/test_steps.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
patch,
2727
)
2828

29-
from sagemaker.debugger import DEBUGGER_FLAG, ProfilerConfig
29+
from sagemaker.debugger import ProfilerConfig
3030
from sagemaker.estimator import Estimator
3131
from sagemaker.tensorflow import TensorFlow
3232
from sagemaker.inputs import TrainingInput, TransformInput, CreateModelInput
@@ -485,7 +485,6 @@ def test_training_step_tensorflow(sagemaker_session):
485485
"sagemaker_distributed_dataparallel_custom_mpi_options": '""',
486486
},
487487
"ProfilerConfig": {"S3OutputPath": "s3://my-bucket/"},
488-
"Environment": {DEBUGGER_FLAG: "0"},
489488
},
490489
"CacheConfig": {"Enabled": True, "ExpireAfter": "PT1H"},
491490
}

0 commit comments

Comments
 (0)