Merge pull request verilog-to-routing#1855 from RapidSilicon/api_set_node_capacity

vaughnbetz · web-flow · commit a86083faf52f · 2021-09-27T19:35:46.000-04:00
Add a new API set_node_capacity() to RRGraphBuilder
diff --git a/vpr/src/device/rr_graph_builder.cpp b/vpr/src/device/rr_graph_builder.cpp
@@ -50,7 +50,3 @@ void RRGraphBuilder::add_node_to_all_locs(RRNodeId node) {
 void RRGraphBuilder::clear() {
     node_lookup_.clear();
 }
-
-void RRGraphBuilder::set_node_coordinates(RRNodeId id, short x1, short y1, short x2, short y2) {
-    node_storage_.set_node_coordinates(id, x1, y1, x2, y2);
-}
diff --git a/vpr/src/device/rr_graph_builder.h b/vpr/src/device/rr_graph_builder.h
@@ -55,8 +55,15 @@ class RRGraphBuilder {
     /** @brief Clear all the underlying data storage */
     void clear();
 
+    /** @brief Set capacity of this node (number of routes that can use it). */
+    inline void set_node_capacity(RRNodeId id, short new_capacity) {
+        node_storage_.set_node_capacity(id, new_capacity);
+    }
+
     /** @brief Set the node coordinate */
-    void set_node_coordinates(RRNodeId id, short x1, short y1, short x2, short y2);
+    inline void set_node_coordinates(RRNodeId id, short x1, short y1, short x2, short y2) {
+        node_storage_.set_node_coordinates(id, x1, y1, x2, y2);
+    }
 
     /* -- Internal data storage -- */
   private:
diff --git a/vpr/src/route/clock_connection_builders.cpp b/vpr/src/route/clock_connection_builders.cpp
@@ -108,7 +108,7 @@ RRNodeId RoutingToClockConnection::create_virtual_clock_network_sink_node(int x,
 
     rr_graph.set_node_ptc_num(node_index, ptc);
     rr_graph_builder.set_node_coordinates(node_index, x, y, x, y);
-    rr_graph.set_node_capacity(node_index, 1);
+    rr_graph_builder.set_node_capacity(node_index, 1);
     rr_graph.set_node_cost_index(node_index, SINK_COST_INDEX);
     rr_graph.set_node_type(node_index, SINK);
     float R = 0.;
diff --git a/vpr/src/route/clock_network_builders.cpp b/vpr/src/route/clock_network_builders.cpp
@@ -321,7 +321,7 @@ int ClockRib::create_chanx_wire(int x_start,
 
     rr_graph_builder.set_node_coordinates(chanx_node, x_start, y, x_end, y);
     node.set_type(CHANX);
-    node.set_capacity(1);
+    rr_graph_builder.set_node_capacity(chanx_node, 1);
     node.set_track_num(ptc_num);
     node.set_rc_index(find_create_rr_rc_data(
         x_chan_wire.layer.r_metal, x_chan_wire.layer.c_metal));
@@ -346,7 +346,6 @@ int ClockRib::create_chanx_wire(int x_start,
 
     /* Add the node to spatial lookup */
     auto& rr_graph = (*rr_nodes);
-
     /* TODO: Will replace these codes with an API add_node_to_all_locs() of RRGraphBuilder */
     for (int ix = rr_graph.node_xlow(chanx_node); ix <= rr_graph.node_xhigh(chanx_node); ++ix) {
         for (int iy = rr_graph.node_ylow(chanx_node); iy <= rr_graph.node_yhigh(chanx_node); ++iy) {
@@ -628,7 +627,7 @@ int ClockSpine::create_chany_wire(int y_start,
 
     rr_graph_builder.set_node_coordinates(chany_node, x, y_start, x, y_end);
     node.set_type(CHANY);
-    node.set_capacity(1);
+    rr_graph_builder.set_node_capacity(chany_node, 1);
     node.set_track_num(ptc_num);
     node.set_rc_index(find_create_rr_rc_data(
         y_chan_wire.layer.r_metal, y_chan_wire.layer.c_metal));
@@ -653,7 +652,6 @@ int ClockSpine::create_chany_wire(int y_start,
 
     /* Add the node to spatial lookup */
     auto& rr_graph = (*rr_nodes);
-
     /* TODO: Will replace these codes with an API add_node_to_all_locs() of RRGraphBuilder */
     for (int ix = rr_graph.node_xlow(chany_node); ix <= rr_graph.node_xhigh(chany_node); ++ix) {
         for (int iy = rr_graph.node_ylow(chany_node); iy <= rr_graph.node_yhigh(chany_node); ++iy) {
diff --git a/vpr/src/route/rr_graph.cpp b/vpr/src/route/rr_graph.cpp
@@ -708,11 +708,11 @@ static void build_rr_graph(const t_graph_type graph_type,
         for (int i = 0; i < num_rr_nodes; i++) {
             if (rr_graph.node_type(RRNodeId(i)) == CHANX) {
                 int ylow = rr_graph.node_ylow(RRNodeId(i));
-                device_ctx.rr_nodes[i].set_capacity(nodes_per_chan.x_list[ylow]);
+                device_ctx.rr_graph_builder.set_node_capacity(RRNodeId(i), nodes_per_chan.x_list[ylow]);
             }
             if (rr_graph.node_type(RRNodeId(i)) == CHANY) {
                 int xlow = rr_graph.node_xlow(RRNodeId(i));
-                device_ctx.rr_nodes[i].set_capacity(nodes_per_chan.y_list[xlow]);
+                device_ctx.rr_graph_builder.set_node_capacity(RRNodeId(i), nodes_per_chan.y_list[xlow]);
             }
         }
     }
@@ -1428,7 +1428,7 @@ static void build_rr_sinks_sources(RRGraphBuilder& rr_graph_builder,
         }
 
         /* Things common to both SOURCEs and SINKs.   */
-        L_rr_node.set_node_capacity(inode, class_inf[iclass].num_pins);
+        rr_graph_builder.set_node_capacity(inode, class_inf[iclass].num_pins);
         rr_graph_builder.set_node_coordinates(inode, i, j, i + type->width - 1, j + type->height - 1);
         float R = 0.;
         float C = 0.;
@@ -1477,7 +1477,7 @@ static void build_rr_sinks_sources(RRGraphBuilder& rr_graph_builder,
 
                         /* Common to both DRIVERs and RECEIVERs */
                         if (inode) {
-                            L_rr_node.set_node_capacity(inode, 1);
+                            rr_graph_builder.set_node_capacity(inode, 1);
                             float R = 0.;
                             float C = 0.;
                             L_rr_node.set_node_rc_index(inode, find_create_rr_rc_data(R, C));
@@ -1657,7 +1657,7 @@ static void build_rr_chan(RRGraphBuilder& rr_graph_builder,
 
         /* Edge arrays have now been built up.  Do everything else.  */
         L_rr_node.set_node_cost_index(node, cost_index_offset + seg_details[track].index());
-        L_rr_node.set_node_capacity(node, 1); /* GLOBAL routing handled elsewhere */
+        rr_graph_builder.set_node_capacity(node, 1); /* GLOBAL routing handled elsewhere */
 
         if (chan_type == CHANX) {
             rr_graph_builder.set_node_coordinates(node, start, y_coord, end, y_coord);
diff --git a/vpr/src/route/rr_graph_uxsdcxx_serializer.h b/vpr/src/route/rr_graph_uxsdcxx_serializer.h
@@ -761,8 +761,9 @@ class RrGraphSerializer final : public uxsd::RrGraphBase<RrGraphContextTypes> {
         const auto& rr_graph = (*rr_graph_);
         rr_nodes_->make_room_for_node(RRNodeId(id));
         auto node = (*rr_nodes_)[id];
+        RRNodeId node_id = node.id();
 
-        node.set_capacity(capacity);
+        rr_graph_builder_->set_node_capacity(node_id, capacity);
         node.set_type(from_uxsd_node_type(type));
 
         switch (rr_graph.node_type(node.id())) {
diff --git a/vpr/src/route/rr_node.cpp b/vpr/src/route/rr_node.cpp
@@ -79,10 +79,6 @@ void t_rr_node::set_rc_index(short new_rc_index) {
     storage_->set_node_rc_index(id_, new_rc_index);
 }
 
-void t_rr_node::set_capacity(short new_capacity) {
-    storage_->set_node_capacity(id_, new_capacity);
-}
-
 void t_rr_node::set_direction(Direction new_direction) {
     storage_->set_node_direction(id_, new_direction);
 }
diff --git a/vpr/src/route/rr_node.h b/vpr/src/route/rr_node.h
@@ -110,8 +110,6 @@ class t_rr_node {
   public: //Mutators
     void set_type(t_rr_type new_type);
 
-    void set_capacity(short);
-
     void set_ptc_num(short);
     void set_pin_num(short);   //Same as set_ptc_num() by checks type() is consistent
     void set_track_num(short); //Same as set_ptc_num() by checks type() is consistent

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,3 @@ void RRGraphBuilder::add_node_to_all_locs(RRNodeId node) {`
`50`	`50`	`void RRGraphBuilder::clear() {`
`51`	`51`	`node_lookup_.clear();`
`52`	`52`	`}`
`53`		`-`
`54`		`-void RRGraphBuilder::set_node_coordinates(RRNodeId id, short x1, short y1, short x2, short y2) {`
`55`		`- node_storage_.set_node_coordinates(id, x1, y1, x2, y2);`
`56`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,6 @@ void t_rr_node::set_rc_index(short new_rc_index) {`
`79`	`79`	`storage_->set_node_rc_index(id_, new_rc_index);`
`80`	`80`	`}`
`81`	`81`
`82`		`-void t_rr_node::set_capacity(short new_capacity) {`
`83`		`- storage_->set_node_capacity(id_, new_capacity);`
`84`		`-}`
`85`		`-`
`86`	`82`	`void t_rr_node::set_direction(Direction new_direction) {`
`87`	`83`	`storage_->set_node_direction(id_, new_direction);`
`88`	`84`	`}`