Skip to content

Commit 4f9b0ce

Browse files
authored
Removes unused Fir_authPhoneNumber (firebase#277)
Removes references of unused Fir_authPhoneNumber and accompanying class.
1 parent 0d0a519 commit 4f9b0ce

File tree

4 files changed

+0
-82
lines changed

4 files changed

+0
-82
lines changed

Example/Auth/Tests/FIRPhoneAuthProviderTests.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
#import "FIRVerifyClientResponse.h"
4444
#import "OCMStubRecorder+FIRAuthUnitTests.h"
4545
#import "Phone/FIRPhoneAuthCredential_Internal.h"
46-
#import "Phone/NSString+FIRAuth.h"
4746

4847
@import SafariServices;
4948

@@ -328,7 +327,6 @@ - (void)testVerifyPhoneNumber {
328327
XCTAssertTrue([NSThread isMainThread]);
329328
XCTAssertNil(error);
330329
XCTAssertEqualObjects(verificationID, kTestVerificationID);
331-
XCTAssertEqualObjects(verificationID.fir_authPhoneNumber, kTestPhoneNumber);
332330
[expectation fulfill];
333331
}];
334332
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];
@@ -443,7 +441,6 @@ - (void)testVerifyPhoneNumberUIDelegate {
443441
XCTAssertTrue([NSThread isMainThread]);
444442
XCTAssertNil(error);
445443
XCTAssertEqualObjects(verificationID, kTestVerificationID);
446-
XCTAssertEqualObjects(verificationID.fir_authPhoneNumber, kTestPhoneNumber);
447444
[expectation fulfill];
448445
}];
449446
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];
@@ -711,7 +708,6 @@ - (void)testVerifyClient {
711708
XCTAssertTrue([NSThread isMainThread]);
712709
XCTAssertNil(error);
713710
XCTAssertEqualObjects(verificationID, kTestVerificationID);
714-
XCTAssertEqualObjects(verificationID.fir_authPhoneNumber, kTestPhoneNumber);
715711
[expectation fulfill];
716712
}];
717713
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];
@@ -893,7 +889,6 @@ - (void)testSendVerificationCodeSuccessFulRetry {
893889
completion:^(NSString *_Nullable verificationID, NSError *_Nullable error) {
894890
XCTAssertNil(error);
895891
XCTAssertEqualObjects(verificationID, kTestVerificationID);
896-
XCTAssertEqualObjects(verificationID.fir_authPhoneNumber, kTestPhoneNumber);
897892
[expectation fulfill];
898893
}];
899894
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];

Firebase/Auth/Source/AuthProviders/Phone/FIRPhoneAuthProvider.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
#import "FIRLogger.h"
2222
#import "FIRPhoneAuthCredential_Internal.h"
23-
#import "NSString+FIRAuth.h"
2423
#import "FIRApp.h"
2524
#import "FIRAuthAPNSToken.h"
2625
#import "FIRAuthAPNSTokenManager.h"
@@ -194,8 +193,6 @@ - (void)verifyPhoneNumber:(NSString *)phoneNumber
194193
callBackOnMainThread(nil, error);
195194
return;
196195
}
197-
// Associate the phone number with the verification ID.
198-
response.verificationID.fir_authPhoneNumber = phoneNumber;
199196
callBackOnMainThread(response.verificationID, nil);
200197
}];
201198
}];
@@ -381,8 +378,6 @@ - (void)verifyClientAndSendVerificationCodeToPhoneNumber:(NSString *)phoneNumber
381378
callback(nil, error);
382379
return;
383380
}
384-
// Associate the phone number with the verification ID.
385-
response.verificationID.fir_authPhoneNumber = phoneNumber;
386381
callback(response.verificationID, nil);
387382
}];
388383
}];

Firebase/Auth/Source/AuthProviders/Phone/NSString+FIRAuth.h

Lines changed: 0 additions & 36 deletions
This file was deleted.

Firebase/Auth/Source/AuthProviders/Phone/NSString+FIRAuth.m

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)