Skip to content

Commit 458554a

Browse files
tweak tests
1 parent 72a949c commit 458554a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

packages/python/plotly/plotly/io/_base_renderers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ def open_html_in_browser(html, using=None, new=0, autoraise=True):
672672
browser = None
673673

674674
if using is None:
675-
browser = webbrowser.get()
675+
browser = webbrowser.get(None)
676676
else:
677677
if not isinstance(using, tuple):
678678
using = (using,)

packages/python/plotly/plotly/tests/test_io/test_renderers.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,14 @@ def test_notebook_connected_show(fig1, name, connected):
221221

222222
# Browser
223223
# -------
224-
@pytest.mark.parametrize("renderer", ["browser", "chrome", "firefox"])
224+
@pytest.mark.parametrize("renderer", ["browser", "chrome", "chromium", "firefox"])
225225
def test_browser_renderer_show(fig1, renderer):
226226
pio.renderers.default = renderer
227227
renderer_obj = pio.renderers[renderer]
228+
using = renderer_obj.using
229+
if isinstance(renderer_obj.using, tuple):
230+
using = renderer_obj.using[0]
231+
renderer_obj.using = using
228232

229233
# Setup mocks
230234
mock_get = MagicMock(name="test get")
@@ -249,11 +253,7 @@ def open_url(url, new=0, autoraise=True):
249253
pio.show(fig1)
250254

251255
# check get args
252-
if isinstance(renderer_obj.using, tuple):
253-
for using in renderer_obj.using:
254-
mock_get.assert_called_with(using)
255-
else:
256-
mock_get.assert_called_once_with(renderer_obj.using)
256+
mock_get.assert_called_once_with(using)
257257

258258
# check open args
259259
mock_call_args = mock_browser.open.call_args

0 commit comments

Comments
 (0)