Skip to content

Commit 8f0e974

Browse files
authored
feat: update bevy to 0.12 (#3)
1. Update Bevy to 0.12 2. Update related deps ( ggrs, bevy_ggrs, matchbox, etc. ) 3. Log warning if winit cannot find main window to avoid panic - I don't understand why this changed see below. 4. Switch to `1.72` toolchain due to Rust compiler regression. ### Winit Panic Some new issue was introduced with the Bevy 0.12 upgrade, this line started panicking, so we just log a warning and abort if we can't get the primary window. https://github.com/mikeder/turtletime/pull/3/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcL83 NiklasEi/bevy_game_template#80 ### Compiler Regression I was unable to compile `bevy-egui-inspector` after updating to Rust to the 1.74 toolchain, it turns out there was a compiler regression so I've pinned my toolchain to 1.72 ( there was [another regression](rust-lang/rust#117545) in 1.73 that sounds nasty enough to avoid for now too ) jakobhellermann/bevy-inspector-egui#163 rust-lang/rust#117976 #### Segmentation Fault Originally I tried to use the `nightly` toolchain as recommended in the above `bevy-egui-inspector` issue, but when I did, my game instantly crashed with a segmentation fault. I tried to use the [sanitizer](https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html) features to debug it, but the game compiled and ran just fine with the sanitizer flags. Ultimately I just downgraded to `1.72` and moved on with my life.
1 parent 20234db commit 8f0e974

File tree

13 files changed

+837
-903
lines changed

13 files changed

+837
-903
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
key: ${{ runner.os }}-cargo-build-stable-${{ hashFiles('**/Cargo.toml') }}
2424
- uses: actions-rs/toolchain@v1
2525
with:
26-
toolchain: stable
26+
toolchain: 1.72
2727
override: true
2828
- name: Install alsa and udev
2929
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
@@ -45,7 +45,7 @@ jobs:
4545
key: ubuntu-latest-cargo-build-stable-${{ hashFiles('**/Cargo.toml') }}
4646
- uses: actions-rs/toolchain@v1
4747
with:
48-
toolchain: stable
48+
toolchain: 1.72
4949
override: true
5050
- name: Install alsa and udev
5151
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
@@ -66,7 +66,7 @@ jobs:
6666
key: ubuntu-latest-cargo-build-stable-${{ hashFiles('**/Cargo.toml') }}
6767
- uses: actions-rs/toolchain@v1
6868
with:
69-
toolchain: stable
69+
toolchain: 1.72
7070
components: rustfmt, clippy
7171
override: true
7272
- name: Install alsa and udev

.github/workflows/deploy-page.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Install rust toolchain
1717
uses: actions-rs/toolchain@v1
1818
with:
19-
toolchain: stable
19+
toolchain: 1.72
2020
override: true
2121
- name: Install Dependencies
2222
run: sudo apt-get update; sudo apt-get install pkg-config libx11-dev libasound2-dev libudev-dev

.github/workflows/release.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- name: Install rust toolchain for Apple Silicon
4848
uses: actions-rs/toolchain@v1
4949
with:
50-
toolchain: stable
50+
toolchain: 1.72
5151
target: aarch64-apple-darwin
5252
override: true
5353
- name: Build release for Apple Silicon
@@ -56,7 +56,7 @@ jobs:
5656
- name: Install rust toolchain for Apple x86
5757
uses: actions-rs/toolchain@v1
5858
with:
59-
toolchain: stable
59+
toolchain: 1.72
6060
target: x86_64-apple-darwin
6161
override: true
6262
- name: Build release for x86 Apple
@@ -95,7 +95,7 @@ jobs:
9595
- name: Install rust toolchain
9696
uses: actions-rs/toolchain@v1
9797
with:
98-
toolchain: stable
98+
toolchain: 1.72
9999
override: true
100100
- name: Install Dependencies
101101
run: sudo apt-get update; sudo apt-get install pkg-config libx11-dev libasound2-dev libudev-dev
@@ -130,7 +130,7 @@ jobs:
130130
- name: Install rust toolchain
131131
uses: actions-rs/toolchain@v1
132132
with:
133-
toolchain: stable
133+
toolchain: 1.72
134134
override: true
135135
- name: Install dotnet
136136
uses: actions/setup-dotnet@v3
@@ -178,7 +178,7 @@ jobs:
178178
- name: Install rust toolchain
179179
uses: actions-rs/toolchain@v1
180180
with:
181-
toolchain: stable
181+
toolchain: 1.72
182182
override: true
183183
- name: Install Dependencies
184184
run: sudo apt-get update; sudo apt-get install pkg-config libx11-dev libasound2-dev libudev-dev

0 commit comments

Comments
 (0)