Finalize view badge proposal (#159679)

* Finalize view badge proposal
Fixes #62783

* Fix compile errors

Author: alexr00

src/vs/workbench/api/common/extHostTreeViews.ts

@@ -23,7 +23,6 @@ import { MarkdownString, ViewBadge, DataTransfer } from 'vs/workbench/api/common
 import { IMarkdownString } from 'vs/base/common/htmlContent';
 import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation';
 import { ITreeViewsService, TreeviewsService } from 'vs/workbench/services/views/common/treeViewsService';
-import { checkProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions';
 
 type TreeItemHandle = string;
 
@@ -115,11 +114,9 @@ export class ExtHostTreeViews implements ExtHostTreeViewsShape {
 				treeView.description = description;
 			},
 			get badge() {
-				checkProposedApiEnabled(extension, 'badges');
 				return treeView.badge;
 			},
 			set badge(badge: vscode.ViewBadge | undefined) {
-				checkProposedApiEnabled(extension, 'badges');
 				treeView.badge = badge;
 			},
 			reveal: (element: T, options?: IRevealOptions): Promise<void> => {

src/vs/workbench/api/common/extHostWebviewView.ts

@@ -8,7 +8,6 @@ import { Emitter } from 'vs/base/common/event';
 import { Disposable } from 'vs/base/common/lifecycle';
 import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
 import { ExtHostWebview, ExtHostWebviews, toExtensionData, shouldSerializeBuffersForPostMessage } from 'vs/workbench/api/common/extHostWebview';
-import { checkProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions';
 import { ViewBadge } from 'vs/workbench/api/common/extHostTypeConverters';
 import type * as vscode from 'vscode';
 import * as extHostProtocol from './extHost.protocol';
@@ -21,7 +20,6 @@ class ExtHostWebviewView extends Disposable implements vscode.WebviewView {
 
 	readonly #viewType: string;
 	readonly #webview: ExtHostWebview;
-	readonly #extension: IExtensionDescription;
 
 	#isDisposed = false;
 	#isVisible: boolean;
@@ -35,7 +33,7 @@ class ExtHostWebviewView extends Disposable implements vscode.WebviewView {
 		viewType: string,
 		title: string | undefined,
 		webview: ExtHostWebview,
-		extension: IExtensionDescription,
+		_extension: IExtensionDescription,
 		isVisible: boolean,
 	) {
 		super();
@@ -45,7 +43,6 @@ class ExtHostWebviewView extends Disposable implements vscode.WebviewView {
 		this.#handle = handle;
 		this.#proxy = proxy;
 		this.#webview = webview;
-		this.#extension = extension;
 		this.#isVisible = isVisible;
 	}
 
@@ -111,13 +108,11 @@ class ExtHostWebviewView extends Disposable implements vscode.WebviewView {
 
 	public get badge(): vscode.ViewBadge | undefined {
 		this.assertNotDisposed();
-		checkProposedApiEnabled(this.#extension, 'badges');
 		return this.#badge;
 	}
 
 	public set badge(badge: vscode.ViewBadge | undefined) {
 		this.assertNotDisposed();
-		checkProposedApiEnabled(this.#extension, 'badges');
 
 		if (badge?.value === this.#badge?.value &&
 			badge?.tooltip === this.#badge?.tooltip) {

src/vs/workbench/services/extensions/common/extensionsApiProposals.ts

@@ -7,7 +7,6 @@
 
 export const allApiProposals = Object.freeze({
 	authSession: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.authSession.d.ts',
-	badges: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.badges.d.ts',
 	commentsResolvedState: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.commentsResolvedState.d.ts',
 	contribCommentPeekContext: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribCommentPeekContext.d.ts',
 	contribEditSessions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribEditSessions.d.ts',

src/vscode-dts/vscode.d.ts

@@ -8636,6 +8636,12 @@ declare module 'vscode' {
 		 */
 		description?: string;
 
+		/**
+		 * The badge to display for this webview view.
+		 * To remove the badge, set to undefined.
+		 */
+		badge?: ViewBadge | undefined;
+
 		/**
 		 * Event fired when the view is disposed.
 		 *
@@ -10322,6 +10328,22 @@ declare module 'vscode' {
 		handleDrop?(target: T | undefined, dataTransfer: DataTransfer, token: CancellationToken): Thenable<void> | void;
 	}
 
+	/**
+	 * A badge presenting a value for a view
+	 */
+	export interface ViewBadge {
+
+		/**
+		 * A label to present in tooltip for the badge.
+		 */
+		readonly tooltip: string;
+
+		/**
+		 * The value to present in the badge.
+		 */
+		readonly value: number;
+	}
+
 	/**
 	 * Represents a Tree view
 	 */
@@ -10375,6 +10397,12 @@ declare module 'vscode' {
 		 */
 		description?: string;
 
+		/**
+		 * The badge to display for this TreeView.
+		 * To remove the badge, set to undefined.
+		 */
+		badge?: ViewBadge | undefined;
+
 		/**
 		 * Reveals the given element in the tree view.
 		 * If the tree view is not visible then the tree view is shown and element is revealed.