Skip to content

Commit af4b19d

Browse files
authored
make eager service registration explicit (#163558)
Related-to: #159178
1 parent 1436dd7 commit af4b19d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { IURLHandler, IURLService, IOpenURLOptions } from 'vs/platform/url/commo
1818
import { IHostService } from 'vs/workbench/services/host/browser/host';
1919
import { IExtensionService, toExtensionDescription } from 'vs/workbench/services/extensions/common/extensions';
2020
import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
21-
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
21+
import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';
2222
import { Registry } from 'vs/platform/registry/common/platform';
2323
import { IWorkbenchContribution, Extensions as WorkbenchExtensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions';
2424
import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle';
@@ -382,7 +382,7 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
382382
}
383383
}
384384

385-
registerSingleton(IExtensionUrlHandler, ExtensionUrlHandler, false);
385+
registerSingleton(IExtensionUrlHandler, ExtensionUrlHandler, InstantiationType.Eager);
386386

387387
/**
388388
* This class handles URLs before `ExtensionUrlHandler` is instantiated.

src/vs/workbench/services/update/browser/updateService.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { Event, Emitter } from 'vs/base/common/event';
77
import { IUpdateService, State, UpdateType } from 'vs/platform/update/common/update';
8-
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
8+
import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';
99
import { IBrowserWorkbenchEnvironmentService } from 'vs/workbench/services/environment/browser/environmentService';
1010
import { IHostService } from 'vs/workbench/services/host/browser/host';
1111
import { Disposable } from 'vs/base/common/lifecycle';
@@ -96,4 +96,4 @@ export class BrowserUpdateService extends Disposable implements IUpdateService {
9696
}
9797
}
9898

99-
registerSingleton(IUpdateService, BrowserUpdateService, false);
99+
registerSingleton(IUpdateService, BrowserUpdateService, InstantiationType.Eager);

src/vs/workbench/services/url/electron-sandbox/urlService.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { IMainProcessService } from 'vs/platform/ipc/electron-sandbox/services';
99
import { URLHandlerChannel } from 'vs/platform/url/common/urlIpc';
1010
import { IOpenerService, IOpener, matchesScheme } from 'vs/platform/opener/common/opener';
1111
import { IProductService } from 'vs/platform/product/common/productService';
12-
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
12+
import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';
1313
import { ProxyChannel } from 'vs/base/parts/ipc/common/ipc';
1414
import { INativeHostService } from 'vs/platform/native/electron-sandbox/native';
1515
import { NativeURLService } from 'vs/platform/url/common/urlService';
@@ -73,4 +73,4 @@ export class RelayURLService extends NativeURLService implements IURLHandler, IO
7373
}
7474
}
7575

76-
registerSingleton(IURLService, RelayURLService, false);
76+
registerSingleton(IURLService, RelayURLService, InstantiationType.Eager);

0 commit comments

Comments
 (0)