Skip to content

Commit 820e70a

Browse files
committed
gh auth: don't reach out to product.json
1 parent 3236b8d commit 820e70a

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

extensions/github-authentication/src/experimentationService.ts

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -51,24 +51,15 @@ export class ExperimentationTelemetry implements IExperimentationTelemetry {
5151
}
5252
}
5353

54-
interface ProductConfiguration {
55-
quality?: 'stable' | 'insider' | 'exploration';
56-
}
57-
58-
async function getProductConfig(appRoot: string): Promise<ProductConfiguration> {
59-
const raw = await vscode.workspace.fs.readFile((vscode.Uri.joinPath(vscode.Uri.file(appRoot), 'product.json')));
60-
return JSON.parse(raw.toString());
61-
}
62-
63-
function getTargetPopulation(product: ProductConfiguration): TargetPopulation {
64-
switch (product.quality) {
65-
case 'stable':
54+
function getTargetPopulation(): TargetPopulation {
55+
switch (vscode.env.uriScheme) {
56+
case 'vscode':
6657
return TargetPopulation.Public;
67-
case 'insider':
58+
case 'vscode-insiders':
6859
return TargetPopulation.Insiders;
69-
case 'exploration':
60+
case 'vscode-exploration':
7061
return TargetPopulation.Internal;
71-
case undefined:
62+
case 'code-oss':
7263
return TargetPopulation.Team;
7364
default:
7465
return TargetPopulation.Public;
@@ -78,7 +69,5 @@ function getTargetPopulation(product: ProductConfiguration): TargetPopulation {
7869
export async function createExperimentationService(context: vscode.ExtensionContext, telemetry: ExperimentationTelemetry): Promise<IExperimentationService> {
7970
const id = context.extension.id;
8071
const version = context.extension.packageJSON.version;
81-
const product = await getProductConfig(vscode.env.appRoot);
82-
const targetPopulation = getTargetPopulation(product);
83-
return getExperimentationService(id, version, targetPopulation, telemetry, context.globalState);
72+
return getExperimentationService(id, version, getTargetPopulation(), telemetry, context.globalState);
8473
}

0 commit comments

Comments
 (0)