Merge pull request #602 from microsoft/sandy081/validateExtensionKind

validate extension kind

Author: joaomoreno

src/package.ts

@@ -1032,6 +1032,16 @@ export function validateManifest(manifest: Manifest): Manifest {
 		}
 	});
 
+	if (manifest.extensionKind) {
+		const extensionKinds: ExtensionKind[] = Array.isArray(manifest.extensionKind)
+			? manifest.extensionKind
+			: [manifest.extensionKind];
+		const validExtensionKinds: ExtensionKind[] = ['ui', 'workspace'];
+		if (extensionKinds.some(extensionKind => !validExtensionKinds.includes(extensionKind))) {
+			throw new Error(`Manifest contains invalid value '${extensionKind}' in the 'extensionKind' property. Allowed values are 'ui', 'workspace'.`);
+		}
+	}
+
 	return manifest;
 }
 

src/test/package.test.ts

@@ -390,6 +390,21 @@ describe('validateManifest', () => {
 		validateManifest(createManifest({ activationEvents: ['any'], browser: 'browser.js' }));
 		validateManifest(createManifest({ activationEvents: ['any'], main: 'main.js', browser: 'browser.js' }));
 	});
+
+	it('should validate extensionKind', () => {
+		assert.throws(() => validateManifest(createManifest({ extensionKind: ['web'] })));
+		assert.throws(() => validateManifest(createManifest({ extensionKind: 'web' })));
+		assert.throws(() => validateManifest(createManifest({ extensionKind: ['workspace', 'ui', 'web'] })));
+		assert.throws(() => validateManifest(createManifest({ extensionKind: ['workspace', 'web'] })));
+		assert.throws(() => validateManifest(createManifest({ extensionKind: ['ui', 'web'] })));
+		assert.throws(() => validateManifest(createManifest(<any>{ extensionKind: ['any'] })));
+		validateManifest(createManifest({ extensionKind: 'ui' }));
+		validateManifest(createManifest({ extensionKind: ['ui'] }));
+		validateManifest(createManifest({ extensionKind: 'workspace' }));
+		validateManifest(createManifest({ extensionKind: ['workspace'] }));
+		validateManifest(createManifest({ extensionKind: ['ui', 'workspace'] }));
+		validateManifest(createManifest({ extensionKind: ['workspace', 'ui'] }));
+	});
 });
 
 describe('toVsixManifest', () => {