Skip to content

Commit 370cffe

Browse files
authored
Rollback packages (#204)
1 parent 2ad7b6e commit 370cffe

File tree

3 files changed

+26
-10
lines changed

3 files changed

+26
-10
lines changed

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@vscode/extension-telemetry",
33
"description": "A module for Visual Studio Code extensions to report consistent telemetry.",
4-
"version": "0.9.4",
4+
"version": "0.9.5",
55
"author": {
66
"name": "Microsoft Corporation"
77
},
@@ -20,9 +20,9 @@
2020
"compile": "tsc -p src/browser/tsconfig.json && tsc -p src/node/tsconfig.json"
2121
},
2222
"dependencies": {
23-
"@microsoft/1ds-core-js": "^4.1.1",
24-
"@microsoft/1ds-post-js": "^4.1.1",
25-
"@microsoft/applicationinsights-web-basic": "^3.1.1"
23+
"@microsoft/1ds-core-js": "^4.0.6",
24+
"@microsoft/1ds-post-js": "^4.0.6",
25+
"@microsoft/applicationinsights-web-basic": "^3.0.8"
2626
},
2727
"devDependencies": {
2828
"@types/mocha": "^10.0.3",

src/common/1dsClientFactory.ts

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import type { AppInsightsCore, IExtendedConfiguration } from "@microsoft/1ds-core-js";
6+
import type { AppInsightsCore, IExtendedConfiguration, IPerfManager } from "@microsoft/1ds-core-js";
77
import type { IChannelConfiguration, IXHROverride, PostChannel } from "@microsoft/1ds-post-js";
88
import type * as vscode from "vscode";
99
import type { BaseTelemetryClient } from "./baseTelemetrySender";
@@ -20,6 +20,19 @@ const getAICore = async (key: string, vscodeAPI: typeof vscode, xhrOverride?: IX
2020
const postPlugin = await import(/* webpackMode: "eager" */ "@microsoft/1ds-post-js");
2121
const appInsightsCore = new oneDs.AppInsightsCore();
2222
const collectorChannelPlugin: PostChannel = new postPlugin.PostChannel();
23+
24+
// Dummy perf manager to fix memory leaks
25+
const perfManager: IPerfManager = {
26+
create: function (_src, _payload, _isAsync) {
27+
return null;
28+
},
29+
fire: function (_perfEvent) {
30+
},
31+
setCtx: function (_key, _value) {
32+
},
33+
getCtx: function (_key) {
34+
}
35+
};
2336
// Configure the app insights core to send to collector++ and disable logging of debug info
2437
const coreConfig: IExtendedConfiguration = {
2538
instrumentationKey: key,
@@ -28,6 +41,9 @@ const getAICore = async (key: string, vscodeAPI: typeof vscode, xhrOverride?: IX
2841
loggingLevelConsole: 0,
2942
disableCookiesUsage: true,
3043
disableDbgExt: true,
44+
createPerfMgr: () => {
45+
return perfManager;
46+
},
3147
disableInstrumentationKeyValidation: true,
3248
channels: [[
3349
collectorChannelPlugin

0 commit comments

Comments
 (0)