Skip to content

Commit 04ff08d

Browse files
authored
Merge pull request #114 from microsoft/lramos15/mute-goose
Don't bundle 1DS as it can cause issues with webpack
2 parents 5834697 + 19cd0eb commit 04ff08d

File tree

3 files changed

+23
-33
lines changed

3 files changed

+23
-33
lines changed

.esbuild.config.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ esbuild.build({
1616
entryPoints: ['src/node/telemetryReporter.ts'],
1717
tsconfig: "./src/node/tsconfig.json",
1818
bundle: true,
19-
external: ['vscode'],
19+
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
2020
sourcemap: true,
2121
platform: 'node',
2222
target: ['node14'],
@@ -28,7 +28,7 @@ esbuild.build({
2828
tsconfig: "./src/node/tsconfig.json",
2929
bundle: true,
3030
sourcemap: false,
31-
external: ['vscode'],
31+
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
3232
minify: true,
3333
platform: 'node',
3434
target: ['node14'],
@@ -42,7 +42,7 @@ esbuild.build({
4242
tsconfig: "./src/browser/tsconfig.json",
4343
bundle: true,
4444
sourcemap: true,
45-
external: ['vscode'],
45+
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
4646
platform: 'browser',
4747
target: ['es6'],
4848
outfile: 'lib/telemetryReporter.web.js',
@@ -54,7 +54,7 @@ esbuild.build({
5454
format: "esm",
5555
bundle: true,
5656
sourcemap: false,
57-
external: ['vscode'],
57+
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
5858
minify: true,
5959
platform: 'browser',
6060
target: ['es6'],

package-lock.json

Lines changed: 14 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@vscode/extension-telemetry",
33
"description": "A module for first party microsoft extensions to report consistent telemetry.",
4-
"version": "0.6.1",
4+
"version": "0.6.2",
55
"author": {
66
"name": "Microsoft Corporation"
77
},
@@ -17,9 +17,11 @@
1717
"test": "tsc -p 'test/tsconfig.json' && mocha lib/test/*",
1818
"compile": "tsc -noEmit -p 'src/browser/tsconfig.json' && tsc -noEmit -p 'src/node/tsconfig.json' && npm run build"
1919
},
20-
"devDependencies": {
20+
"dependencies": {
2121
"@microsoft/1ds-core-js": "^3.2.3",
22-
"@microsoft/1ds-post-js": "^3.2.3",
22+
"@microsoft/1ds-post-js": "^3.2.3"
23+
},
24+
"devDependencies": {
2325
"@microsoft/applicationinsights-web": "^2.6.4",
2426
"@types/mocha": "^9.1.1",
2527
"@types/node": "^16.11.32",

0 commit comments

Comments
 (0)