Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

add sketch folder to examples #654

Merged
merged 6 commits into from
Nov 15, 2018
Merged

add sketch folder to examples #654

merged 6 commits into from
Nov 15, 2018

Conversation

aster94
Copy link
Contributor

@aster94 aster94 commented Sep 7, 2018

solves #652
screenshot 2018-09-07 15 25 29

video:
https://streamable.com/llhuc

@czgtest also said it would be a nice feature

@aster94 aster94 mentioned this pull request Sep 8, 2018
Copy link
Contributor

@czgtest czgtest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you build pass for using this.parseExamples(sketchesPath, true, true) ?

@aster94
Copy link
Contributor Author

aster94 commented Nov 14, 2018

Yes, i also made a video to show it in the first post

@czgtest
Copy link
Contributor

czgtest commented Nov 14, 2018

@aster94 parseExamples methold only need 1 arguments, but got 3
image

@aster94
Copy link
Contributor Author

aster94 commented Nov 14, 2018

@czgtest you are right. Corrected
I mush have mistaken it with parseExamplesFromLibrary which need three arguments

@czgtest
Copy link
Contributor

czgtest commented Nov 14, 2018

@aster94 can you use the first letter lowercase for "Sketches" in code ?
path.join(this._settings.sketchbookPath, "Sketches");

image

btw, if your folder named "Sketches" , it also can be opened in arduino example.

@aster94
Copy link
Contributor Author

aster94 commented Nov 14, 2018

@czgtest done!

@czgtest
Copy link
Contributor

czgtest commented Nov 15, 2018

Thank you a lot @aster94

@czgtest czgtest merged commit 3cd10f3 into microsoft:master Nov 15, 2018
@aster94 aster94 deleted the add-sketch-folder branch November 15, 2018 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants