From 0f25844bfb2ae2a42590b0b66bffbe05ff19290e Mon Sep 17 00:00:00 2001 From: BelKed <66956532+BelKed@users.noreply.github.com> Date: Thu, 24 Mar 2022 17:58:48 +0100 Subject: [PATCH 1/3] Replace the activation event `*` with `onLanguage:cpp` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index db3b29d5..eb1f86ec 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "C++" ], "activationEvents": [ - "*", + "onLanguage:cpp", "onCommand:arduino.verify", "onCommand:arduino.upload", "onCommand:arduino.cliUpload", From 7331839cfd549543df7a70e63816998723b3f3ba Mon Sep 17 00:00:00 2001 From: BelKed <66956532+BelKed@users.noreply.github.com> Date: Thu, 24 Mar 2022 17:59:33 +0100 Subject: [PATCH 2/3] Fix typo in `onCommand:arduino.cliUploadUsingProgrammer` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index eb1f86ec..843d105e 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "onCommand:arduino.upload", "onCommand:arduino.cliUpload", "onCommand:arduino.uploadUsingProgrammer", - "onCommand:arduiono.cliUploadUsingProgrammer", + "onCommand:arduino.cliUploadUsingProgrammer", "onCommand:arduino.rebuildIntelliSenseConfig", "onCommand:arduino.selectProgrammer", "onCommand:arduino.selectSerialPort", From 8b42e3819672236f7379ad972a026a4bba2d5fb4 Mon Sep 17 00:00:00 2001 From: Ben McMorran Date: Thu, 24 Mar 2022 11:04:38 -0700 Subject: [PATCH 3/3] Update test to account for command setTimeout --- test/commands.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/commands.test.ts b/test/commands.test.ts index 5f07f069..ddf2e227 100644 --- a/test/commands.test.ts +++ b/test/commands.test.ts @@ -13,7 +13,9 @@ suite("Arduino: Commands Tests", () => { const extension = vscode.extensions.getExtension("vsciot-vscode.vscode-arduino"); if (!extension.isActive) { extension.activate().then((api) => { - done(); + // The extension waits 100ms before registering some commands, + // so add a longer delay here before running tests. + setTimeout(() => done(), 200); }, () => { done("Failed to activate extension"); });