From e504be8a19c6ada5a1c3da9145eabef2e645048e Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 09:48:34 -0800
Subject: [PATCH 01/51] github action tests

---
 .github/workflows/build.yml | 54 +++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
new file mode 100644
index 00000000..adcc1736
--- /dev/null
+++ b/.github/workflows/build.yml
@@ -0,0 +1,54 @@
+name: CI-Tests
+on: 
+  push:
+    branches:
+      - master
+      - develop
+    tags:
+      - v*.*.*
+      - v*.*.*-RC*
+  pull_request:
+    branches:
+      - master
+      - develop
+
+jobs:
+    build:
+      strategy:
+        matrix:
+          os: [ubuntu-trusty, macos-latest, windows-latest]
+    runs-on: ${{ matrix.os }} 
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 11.x
+      - name: linux setup
+        if: ${{ matrix.os }} == ubuntu-trusty
+        run: |
+          export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
+          sleep 3
+          wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
+          tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
+          sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
+          sudo apt-get update
+          sudo apt-get install g++-multilib
+          sudo apt-get install -y build-essential
+          sudo apt-get install libudev-dev
+      - name: macos setup
+        if: ${{ matrix.os }} == macos-latest
+        run: | 
+          /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
+          brew cask install arduino
+      - run: | 
+          npm install -g node-gyp
+          npm install -g vsce
+          npm install -g gulp
+          npm install -g 
+          npm install
+          gulp tslint
+          gulp genAikey
+          vsce package
+      - name: run tests
+        uses: GabrielBB/xvfb-action@v1
+        run: npm test --silent

From b140078db055680bcff8bbd350d0ad6385769280 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 09:51:15 -0800
Subject: [PATCH 02/51] fix indent

---
 .github/workflows/build.yml | 70 ++++++++++++++++++-------------------
 1 file changed, 35 insertions(+), 35 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index adcc1736..51861223 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -17,38 +17,38 @@ jobs:
       strategy:
         matrix:
           os: [ubuntu-trusty, macos-latest, windows-latest]
-    runs-on: ${{ matrix.os }} 
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 11.x
-      - name: linux setup
-        if: ${{ matrix.os }} == ubuntu-trusty
-        run: |
-          export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
-          sleep 3
-          wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
-          tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
-          sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
-          sudo apt-get update
-          sudo apt-get install g++-multilib
-          sudo apt-get install -y build-essential
-          sudo apt-get install libudev-dev
-      - name: macos setup
-        if: ${{ matrix.os }} == macos-latest
-        run: | 
-          /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
-          brew cask install arduino
-      - run: | 
-          npm install -g node-gyp
-          npm install -g vsce
-          npm install -g gulp
-          npm install -g 
-          npm install
-          gulp tslint
-          gulp genAikey
-          vsce package
-      - name: run tests
-        uses: GabrielBB/xvfb-action@v1
-        run: npm test --silent
+      runs-on: ${{ matrix.os }} 
+      steps:
+        - uses: actions/checkout@v2
+        - uses: actions/setup-node@v1
+          with:
+            node-version: 11.x
+        - name: linux setup
+          if: ${{ matrix.os }} == ubuntu-trusty
+          run: |
+            export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
+            sleep 3
+            wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
+            tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
+            sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
+            sudo apt-get update
+            sudo apt-get install g++-multilib
+            sudo apt-get install -y build-essential
+            sudo apt-get install libudev-dev
+        - name: macos setup
+          if: ${{ matrix.os }} == macos-latest
+          run: | 
+            /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
+            brew cask install arduino
+        - run: | 
+            npm install -g node-gyp
+            npm install -g vsce
+            npm install -g gulp
+            npm install -g 
+            npm install
+            gulp tslint
+            gulp genAikey
+            vsce package
+        - name: run tests
+          uses: GabrielBB/xvfb-action@v1
+          run: npm test --silent

From 71d9253b8f2c1ce832f1b6cf39d68b3ae747d503 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 09:53:35 -0800
Subject: [PATCH 03/51] fix xvfb action

---
 .github/workflows/build.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 51861223..58d37455 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -51,4 +51,5 @@ jobs:
             vsce package
         - name: run tests
           uses: GabrielBB/xvfb-action@v1
-          run: npm test --silent
+          with:
+            run: npm test --silent

From 3f29ff1630cd6770a8083ad32efc6bb7e0bfe7cf Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:20:10 -0800
Subject: [PATCH 04/51] trigger

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 58d37455..d23cfc15 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -12,6 +12,7 @@ on:
       - master
       - develop
 
+
 jobs:
     build:
       strategy:

From 4fe337b6ceade35e11d0b4c4199418c1711c5aa0 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:21:33 -0800
Subject: [PATCH 05/51] change to @default-branch

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d23cfc15..2da8d9ef 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -2,14 +2,14 @@ name: CI-Tests
 on: 
   push:
     branches:
-      - master
+      - $default-branch
       - develop
     tags:
       - v*.*.*
       - v*.*.*-RC*
   pull_request:
     branches:
-      - master
+      - $default-branch
       - develop
 
 

From 8ac22ab6adc3d0133a7db654758645090d9c0665 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:24:11 -0800
Subject: [PATCH 06/51] update branch names

---
 .github/workflows/build.yml | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2da8d9ef..e8187a4f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,16 +1,12 @@
 name: CI-Tests
 on: 
   push:
-    branches:
-      - $default-branch
-      - develop
+    branches: [ $default-branch, develop ]
     tags:
       - v*.*.*
       - v*.*.*-RC*
   pull_request:
-    branches:
-      - $default-branch
-      - develop
+    branches: [ $default-branch, develop ]
 
 
 jobs:

From 28c0d92b11152835f99154d40ea01e4790dafe6a Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:25:11 -0800
Subject: [PATCH 07/51] update linux ver

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e8187a4f..d2eec874 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -13,7 +13,7 @@ jobs:
     build:
       strategy:
         matrix:
-          os: [ubuntu-trusty, macos-latest, windows-latest]
+          os: [ubuntu-latest, macos-latest, windows-latest]
       runs-on: ${{ matrix.os }} 
       steps:
         - uses: actions/checkout@v2

From b7c3eeb7bc59bd6e56ce87286888e41a14a908f5 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:27:10 -0800
Subject: [PATCH 08/51] fix formatting

---
 .github/workflows/build.yml | 83 +++++++++++++++++++------------------
 1 file changed, 43 insertions(+), 40 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d2eec874..01284d86 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -10,43 +10,46 @@ on:
 
 
 jobs:
-    build:
-      strategy:
-        matrix:
-          os: [ubuntu-latest, macos-latest, windows-latest]
-      runs-on: ${{ matrix.os }} 
-      steps:
-        - uses: actions/checkout@v2
-        - uses: actions/setup-node@v1
-          with:
-            node-version: 11.x
-        - name: linux setup
-          if: ${{ matrix.os }} == ubuntu-trusty
-          run: |
-            export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
-            sleep 3
-            wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
-            tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
-            sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
-            sudo apt-get update
-            sudo apt-get install g++-multilib
-            sudo apt-get install -y build-essential
-            sudo apt-get install libudev-dev
-        - name: macos setup
-          if: ${{ matrix.os }} == macos-latest
-          run: | 
-            /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
-            brew cask install arduino
-        - run: | 
-            npm install -g node-gyp
-            npm install -g vsce
-            npm install -g gulp
-            npm install -g 
-            npm install
-            gulp tslint
-            gulp genAikey
-            vsce package
-        - name: run tests
-          uses: GabrielBB/xvfb-action@v1
-          with:
-            run: npm test --silent
+  build:
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+    
+    runs-on: ${{ matrix.os }} 
+    
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 11.x
+      - name: linux setup
+        if: ${{ matrix.os }} == ubuntu-trusty
+        run: |
+          export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
+          sleep 3
+          wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
+          tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
+          sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
+          sudo apt-get update
+          sudo apt-get install g++-multilib
+          sudo apt-get install -y build-essential
+          sudo apt-get install libudev-dev
+      - name: macos setup
+        if: ${{ matrix.os }} == macos-latest
+        run: | 
+          /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
+          brew cask install arduino
+      - run: | 
+          npm install -g node-gyp
+          npm install -g vsce
+          npm install -g gulp
+          npm install -g 
+          npm install
+          gulp tslint
+          gulp genAikey
+          vsce package
+      - name: run tests
+        uses: GabrielBB/xvfb-action@v1
+        with:
+          run: npm test --silent

From 7cd76b6fac5952f37706e339040619b6fa81333d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:31:35 -0800
Subject: [PATCH 09/51] remove tags and develop triggers

---
 .github/workflows/build.yml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 01284d86..6ee711bc 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,19 +1,20 @@
 name: CI-Tests
 on: 
   push:
-    branches: [ $default-branch, develop ]
-    tags:
-      - v*.*.*
-      - v*.*.*-RC*
+    branches: [ $default-branch ]
+    # tags:
+    #   - v*.*.*
+    #   - v*.*.*-RC*
   pull_request:
     branches: [ $default-branch, develop ]
 
 
 jobs:
   build:
+
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ ubuntu-latest, macos-latest, windows-latest ]
     
     runs-on: ${{ matrix.os }} 
     

From 2e4c5a783540a38576ddbeb67a0732bc01476f1b Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:34:17 -0800
Subject: [PATCH 10/51] move runs-on

---
 .github/workflows/build.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6ee711bc..08ad99ac 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -12,11 +12,10 @@ on:
 jobs:
   build:
 
+    runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        os: [ ubuntu-latest, macos-latest, windows-latest ]
-    
-    runs-on: ${{ matrix.os }} 
+        os: [ ubuntu-latest, macos-latest, windows-latest ] 
     
     steps:
       - name: Checkout

From 449b02057cb411705a9399ef88c4bd211e1d7194 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:37:23 -0800
Subject: [PATCH 11/51] add os target echo

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 08ad99ac..99319ef6 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,6 +20,7 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
+      - run: echo ${{ matrix.TARGET }}
       - uses: actions/setup-node@v1
         with:
           node-version: 11.x

From 46f4937066ce0af838ed5df890631ca2b15e3c4c Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:38:22 -0800
Subject: [PATCH 12/51] change to build on any push

---
 .github/workflows/build.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 99319ef6..756aabc7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,12 +1,12 @@
 name: CI-Tests
-on: 
-  push:
-    branches: [ $default-branch ]
-    # tags:
-    #   - v*.*.*
-    #   - v*.*.*-RC*
-  pull_request:
-    branches: [ $default-branch, develop ]
+on: push
+  # push:
+  #   branches: [ $default-branch ]
+  #   # tags:
+  #   #   - v*.*.*
+  #   #   - v*.*.*-RC*
+  # pull_request:
+  #   branches: [ $default-branch, develop ]
 
 
 jobs:

From 995167b603482c55fce5accff64fba035e06b3f0 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:40:08 -0800
Subject: [PATCH 13/51] remove echo

---
 .github/workflows/build.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 756aabc7..687cf5fd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,7 +20,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
-      - run: echo ${{ matrix.TARGET }}
       - uses: actions/setup-node@v1
         with:
           node-version: 11.x

From 851965c9aba660810d1cbcdbbe3c5f0b5b57dca6 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:43:46 -0800
Subject: [PATCH 14/51] fix linux if

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 687cf5fd..baa31a44 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -24,7 +24,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os }} == ubuntu-trusty
+        if: ${{ matrix.os }} == ubuntu-latest
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3

From 75b104468a1ff955e5c2fc8cc9ba807fdb559bac Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:47:04 -0800
Subject: [PATCH 15/51] fix os ifs

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index baa31a44..01ec5415 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -24,7 +24,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os }} == ubuntu-latest
+        if: ${{ matrix.os == ubuntu-latest }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3
@@ -36,7 +36,7 @@ jobs:
           sudo apt-get install -y build-essential
           sudo apt-get install libudev-dev
       - name: macos setup
-        if: ${{ matrix.os }} == macos-latest
+        if: ${{ matrix.os == macos-latest }}
         run: | 
           /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
           brew cask install arduino

From 53cc8a90024fad94f42dcf73268d5e32e011a74d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:48:16 -0800
Subject: [PATCH 16/51] add ' to ifs

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 01ec5415..485c2c9f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -24,7 +24,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os == ubuntu-latest }}
+        if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3
@@ -36,7 +36,7 @@ jobs:
           sudo apt-get install -y build-essential
           sudo apt-get install libudev-dev
       - name: macos setup
-        if: ${{ matrix.os == macos-latest }}
+        if: ${{ matrix.os == 'macos-latest' }}
         run: | 
           /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
           brew cask install arduino

From bfcc5361e81009fc6c2d8cd205f224f1fcf32268 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 10:52:44 -0800
Subject: [PATCH 17/51] fix brew install

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 485c2c9f..f29672e3 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -39,7 +39,7 @@ jobs:
         if: ${{ matrix.os == 'macos-latest' }}
         run: | 
           /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
-          brew cask install arduino
+          brew install arduino --cask
       - run: | 
           npm install -g node-gyp
           npm install -g vsce

From d93a138f4895afd27459c46bb0735a732578f9ca Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:32:22 -0800
Subject: [PATCH 18/51] remove tests for win

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f29672e3..6955977b 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -50,6 +50,7 @@ jobs:
           gulp genAikey
           vsce package
       - name: run tests
+        if: ${{ matrix.os == 'ubuntu-latest' || 'macos-latest'}}
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent

From ddc01140d103798d7bdbdb27fb687b7a020dd7f6 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:40:30 -0800
Subject: [PATCH 19/51] name steps, add typescript install

---
 .github/workflows/build.yml | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6955977b..80db3bf6 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,9 +20,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 11.x
+      - name: Get Node
+        uses: actions/setup-node@v1
+          with:
+            node-version: 11.x
       - name: linux setup
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
@@ -38,19 +39,23 @@ jobs:
       - name: macos setup
         if: ${{ matrix.os == 'macos-latest' }}
         run: | 
-          /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
+          usr/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
           brew install arduino --cask
-      - run: | 
-          npm install -g node-gyp
-          npm install -g vsce
-          npm install -g gulp
-          npm install -g 
-          npm install
-          gulp tslint
-          gulp genAikey
-          vsce package
+      - name: preinstall 
+        run: | 
+            npm install -g node-gyp
+            npm install -g vsce
+            npm install -g gulp
+            npm install -g typescript
+      - name: install
+        run: npm install
+      - name: scripts
+        run: |
+            gulp tslint
+            gulp genAikey
+            vsce package
       - name: run tests
-        if: ${{ matrix.os == 'ubuntu-latest' || 'macos-latest'}}
+        if: ${{ matrix.os == 'ubuntu-latest' }} || ${{ matrix.os == 'macos-latest' }}
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent

From 143087f5418df31a5df59696d33f94664692d5a8 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:41:16 -0800
Subject: [PATCH 20/51] fix syntax

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 80db3bf6..c17b5481 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -22,8 +22,8 @@ jobs:
         uses: actions/checkout@v2
       - name: Get Node
         uses: actions/setup-node@v1
-          with:
-            node-version: 11.x
+        with:
+          node-version: 11.x
       - name: linux setup
         if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |

From bab6d31f26f8725831c5131dba734ffb3f6b414b Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:46:12 -0800
Subject: [PATCH 21/51] fix formatting

---
 .github/workflows/build.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c17b5481..48ae774d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -39,21 +39,21 @@ jobs:
       - name: macos setup
         if: ${{ matrix.os == 'macos-latest' }}
         run: | 
-          usr/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
+          /usr/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
           brew install arduino --cask
       - name: preinstall 
         run: | 
-            npm install -g node-gyp
-            npm install -g vsce
-            npm install -g gulp
-            npm install -g typescript
+          npm install -g node-gyp
+          npm install -g vsce
+          npm install -g gulp
+          npm install -g typescript
       - name: install
         run: npm install
       - name: scripts
         run: |
-            gulp tslint
-            gulp genAikey
-            vsce package
+          gulp tslint
+          gulp genAikey
+          vsce package
       - name: run tests
         if: ${{ matrix.os == 'ubuntu-latest' }} || ${{ matrix.os == 'macos-latest' }}
         uses: GabrielBB/xvfb-action@v1

From 463507d0a57f99e12326a03b4780066782749638 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:52:33 -0800
Subject: [PATCH 22/51] fix tests

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 48ae774d..e3820683 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -39,7 +39,7 @@ jobs:
       - name: macos setup
         if: ${{ matrix.os == 'macos-latest' }}
         run: | 
-          /usr/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
+          /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
           brew install arduino --cask
       - name: preinstall 
         run: | 
@@ -55,7 +55,7 @@ jobs:
           gulp genAikey
           vsce package
       - name: run tests
-        if: ${{ matrix.os == 'ubuntu-latest' }} || ${{ matrix.os == 'macos-latest' }}
+        if: ${{ matrix.os != windows-latest' }}
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent

From 5948525af6744f523b69bf122623a283a726c4c2 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 11:53:28 -0800
Subject: [PATCH 23/51] add missing '

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e3820683..cc1f1562 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -55,7 +55,7 @@ jobs:
           gulp genAikey
           vsce package
       - name: run tests
-        if: ${{ matrix.os != windows-latest' }}
+        if: ${{ matrix.os != 'windows-latest' }}
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent

From 161278e3c8f2a58a800d74a4a249f029ead947c4 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:01:19 -0800
Subject: [PATCH 24/51] change to trusty

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index cc1f1562..78c686ce 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        os: [ ubuntu-latest, macos-latest, windows-latest ] 
+        os: [ ubuntu-trusty, macos-latest, windows-latest ] 
     
     steps:
       - name: Checkout
@@ -25,7 +25,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os == 'ubuntu-latest' }}
+        if: ${{ matrix.os == 'ubuntu-trusty' }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3

From 6d7838cbed43b35025763593dc0e597734a63dc4 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:02:38 -0800
Subject: [PATCH 25/51] change to ubuntu-14.04.6

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 78c686ce..ae76ed4e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        os: [ ubuntu-trusty, macos-latest, windows-latest ] 
+        os: [ ubuntu-14.04.6, macos-latest, windows-latest ] 
     
     steps:
       - name: Checkout
@@ -25,7 +25,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os == 'ubuntu-trusty' }}
+        if: ${{ matrix.os == 'ubuntu-14.04.6' }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3

From 2dc84f549baf1f79f90510b0337fdb3405123219 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:04:04 -0800
Subject: [PATCH 26/51] revert to 5948525

---
 .github/workflows/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ae76ed4e..cc1f1562 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        os: [ ubuntu-14.04.6, macos-latest, windows-latest ] 
+        os: [ ubuntu-latest, macos-latest, windows-latest ] 
     
     steps:
       - name: Checkout
@@ -25,7 +25,7 @@ jobs:
         with:
           node-version: 11.x
       - name: linux setup
-        if: ${{ matrix.os == 'ubuntu-14.04.6' }}
+        if: ${{ matrix.os == 'ubuntu-latest' }}
         run: |
           export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
           sleep 3

From dc08655e9a9d3a6b4e1721be3d06a85b3c94af2a Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:06:54 -0800
Subject: [PATCH 27/51] remove gulp install

---
 .github/workflows/build.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index cc1f1562..5ff62555 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -45,7 +45,6 @@ jobs:
         run: | 
           npm install -g node-gyp
           npm install -g vsce
-          npm install -g gulp
           npm install -g typescript
       - name: install
         run: npm install

From e3d153733847f4a582a8330faaa0eed04ad40f1a Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:09:31 -0800
Subject: [PATCH 28/51] remove typescript install

---
 .github/workflows/build.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 5ff62555..6efaed14 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -45,7 +45,6 @@ jobs:
         run: | 
           npm install -g node-gyp
           npm install -g vsce
-          npm install -g typescript
       - name: install
         run: npm install
       - name: scripts

From 7e807b9372296426440991698ef2218b1a98660c Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:15:10 -0800
Subject: [PATCH 29/51] add gulp install back

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6efaed14..5fc66899 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -45,6 +45,7 @@ jobs:
         run: | 
           npm install -g node-gyp
           npm install -g vsce
+          npm install -g gulp
       - name: install
         run: npm install
       - name: scripts

From ae314d0370d22d5d2971bd89c68228f655d2eaec Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:27:32 -0800
Subject: [PATCH 30/51] add triggers

---
 .github/workflows/build.yml | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 5fc66899..3f670ab4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,12 +1,16 @@
 name: CI-Tests
-on: push
-  # push:
-  #   branches: [ $default-branch ]
-  #   # tags:
-  #   #   - v*.*.*
-  #   #   - v*.*.*-RC*
-  # pull_request:
-  #   branches: [ $default-branch, develop ]
+on:
+  push:
+    branches:
+      - $default-branch
+      - develop
+    tags:
+      - v*.*.*
+      - v*.*.*-RC*
+  pull_request:
+    branches:
+      - $default-branch
+      - develop
 
 
 jobs:

From dd402a532578a91f3db006c3d301e5fdffe99a0d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:28:59 -0800
Subject: [PATCH 31/51] add actions branch trigger

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3f670ab4..4d405cf8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -2,7 +2,7 @@ name: CI-Tests
 on:
   push:
     branches:
-      - $default-branch
+      - actions
       - develop
     tags:
       - v*.*.*

From 65d99c2f8fa39eb241fd96d6590cf3c4a3aa9d8d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:37:23 -0800
Subject: [PATCH 32/51] add package

---
 .github/workflows/build.yml | 32 ++++++++++++++++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 4d405cf8..e8520d30 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -9,12 +9,12 @@ on:
       - v*.*.*-RC*
   pull_request:
     branches:
-      - $default-branch
+      - master
       - develop
 
 
 jobs:
-  build:
+  Build:
 
     runs-on: ${{ matrix.os }} 
     strategy:
@@ -62,3 +62,31 @@ jobs:
         uses: GabrielBB/xvfb-action@v1
         with:
           run: npm test --silent
+  
+  package:
+    needs: build
+    runs-on: windows-latest
+
+    steps:
+    - name: Checkout
+        uses: actions/checkout@v2
+    - name: Get Node
+      uses: actions/setup-node@v1
+      with:
+        node-version: 11.x
+    - name: preinstall 
+        run: | 
+          npm install -g node-gyp
+          npm install -g vsce
+          npm install -g gulp
+    - name: install
+      run: npm install
+    - name: scripts
+      run: |
+        gulp tslint
+        gulp genAikey
+        vsce package
+        npm run package
+      
+
+

From cafe8adbcde3ba780445d74b97f38fc67f152b96 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 12:38:03 -0800
Subject: [PATCH 33/51] fix indents

---
 .github/workflows/build.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e8520d30..ac4252db 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -69,16 +69,16 @@ jobs:
 
     steps:
     - name: Checkout
-        uses: actions/checkout@v2
+      uses: actions/checkout@v2
     - name: Get Node
       uses: actions/setup-node@v1
       with:
         node-version: 11.x
     - name: preinstall 
-        run: | 
-          npm install -g node-gyp
-          npm install -g vsce
-          npm install -g gulp
+      run: | 
+        npm install -g node-gyp
+        npm install -g vsce
+        npm install -g gulp
     - name: install
       run: npm install
     - name: scripts

From 75157f631418f4181145304305d8607ff57ee764 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Mon, 1 Feb 2021 13:02:18 -0800
Subject: [PATCH 34/51] add artifact publishing

---
 .github/workflows/build.yml | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ac4252db..9b1ca856 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -63,11 +63,14 @@ jobs:
         with:
           run: npm test --silent
   
-  package:
-    needs: build
+  Package:
+    needs: Build
     runs-on: windows-latest
-
+    # if: github.ref = 'refs/tags/v*.*.*'
+    env:
+      VERSION: github.ref = 'refs/tags/v*.*.*'
     steps:
+    - run: echo ${{env.VERSION}}
     - name: Checkout
       uses: actions/checkout@v2
     - name: Get Node
@@ -86,7 +89,11 @@ jobs:
         gulp tslint
         gulp genAikey
         vsce package
-        npm run package
+    - name: create artifact
+      uses: actions/upload-artifact@v1
+      with:
+        name: ${{ env.ver }}.vsix
+        path: ${{githubworkspace}}/vscode-arduino/vscode-arduino/vscode-arduino-0.3.4.vsix
       
 
 

From 963f0d6507213974c2d031deecfe741d5fbe0e9a Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 08:50:49 -0800
Subject: [PATCH 35/51] test package

---
 .github/workflows/build.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9b1ca856..49b6bac7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -5,8 +5,8 @@ on:
       - actions
       - develop
     tags:
-      - v*.*.*
-      - v*.*.*-RC*
+      - v*
+      - v*.*.*-[a-zA-Z]*
   pull_request:
     branches:
       - master
@@ -19,7 +19,8 @@ jobs:
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        os: [ ubuntu-latest, macos-latest, windows-latest ] 
+        # os: [ ubuntu-latest, macos-latest, windows-latest ] 
+        os: windows-latest
     
     steps:
       - name: Checkout
@@ -66,9 +67,9 @@ jobs:
   Package:
     needs: Build
     runs-on: windows-latest
-    # if: github.ref = 'refs/tags/v*.*.*'
     env:
-      VERSION: github.ref = 'refs/tags/v*.*.*'
+      VERSION: ${GITHUB_REF#refs/tags/*/}
+    # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
     - run: echo ${{env.VERSION}}
     - name: Checkout
@@ -92,8 +93,8 @@ jobs:
     - name: create artifact
       uses: actions/upload-artifact@v1
       with:
-        name: ${{ env.ver }}.vsix
-        path: ${{githubworkspace}}/vscode-arduino/vscode-arduino/vscode-arduino-0.3.4.vsix
+        name: vscode-arduino-${{env.VERSION}}.vsix
+        path: ${{github.workspace}}/vscode-arduino/vscode-arduino/vscode-arduino-0.3.4.vsix
       
 
 

From 275265ded83484847e119a4d16be585c39b15b3d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 08:52:20 -0800
Subject: [PATCH 36/51] fix matrix

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 49b6bac7..2e0d2cf8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         # os: [ ubuntu-latest, macos-latest, windows-latest ] 
-        os: windows-latest
+        os: [ swindows-latest ]
     
     steps:
       - name: Checkout

From c20ff0496faefb33fb118e3eb9fac3caf86d729d Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 08:52:54 -0800
Subject: [PATCH 37/51] typo

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2e0d2cf8..d30573eb 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         # os: [ ubuntu-latest, macos-latest, windows-latest ] 
-        os: [ swindows-latest ]
+        os: [ windows-latest ]
     
     steps:
       - name: Checkout

From 13c41b3eb5e262dae92d3b8cbecd6a10089d665c Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 08:59:53 -0800
Subject: [PATCH 38/51] fix version

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d30573eb..3b812b78 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -68,7 +68,7 @@ jobs:
     needs: Build
     runs-on: windows-latest
     env:
-      VERSION: ${GITHUB_REF#refs/tags/*/}
+      VERSION: ${{ GITHUB_REF#refs/tags/*/ }}
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
     - run: echo ${{env.VERSION}}

From 5a062c94c252a466c88510996402efa62b7c7472 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 09:03:46 -0800
Subject: [PATCH 39/51] fix version

---
 .github/workflows/build.yml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3b812b78..1fd3af05 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -67,11 +67,9 @@ jobs:
   Package:
     needs: Build
     runs-on: windows-latest
-    env:
-      VERSION: ${{ GITHUB_REF#refs/tags/*/ }}
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
-    - run: echo ${{env.VERSION}}
+    - run: echo "VERSION=${GITHUB_REF#refs/tags/*/}" >> $GITHUB_ENV
     - name: Checkout
       uses: actions/checkout@v2
     - name: Get Node

From 03ebfef9259b1faf0c0b6252a0f6ebe92316ffe7 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 09:38:08 -0800
Subject: [PATCH 40/51] fix export path

---
 .github/workflows/build.yml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1fd3af05..2b0c01a6 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -92,7 +92,4 @@ jobs:
       uses: actions/upload-artifact@v1
       with:
         name: vscode-arduino-${{env.VERSION}}.vsix
-        path: ${{github.workspace}}/vscode-arduino/vscode-arduino/vscode-arduino-0.3.4.vsix
-      
-
-
+        path: ${{github.workspace}}\*.vsix

From db2556684a78d726f9eab34aa11d4f5c1743631f Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 09:57:30 -0800
Subject: [PATCH 41/51] test package dir, change to ubuntu

---
 .github/workflows/build.yml | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2b0c01a6..eafb4092 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -66,7 +66,7 @@ jobs:
   
   Package:
     needs: Build
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
     - run: echo "VERSION=${GITHUB_REF#refs/tags/*/}" >> $GITHUB_ENV
@@ -76,6 +76,18 @@ jobs:
       uses: actions/setup-node@v1
       with:
         node-version: 11.x
+    - name: linux setup
+      if: ${{ matrix.os == 'ubuntu-latest' }}
+      run: |
+        export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
+        sleep 3
+        wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
+        tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
+        sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
+        sudo apt-get update
+        sudo apt-get install g++-multilib
+        sudo apt-get install -y build-essential
+        sudo apt-get install libudev-dev
     - name: preinstall 
       run: | 
         npm install -g node-gyp
@@ -87,9 +99,11 @@ jobs:
       run: |
         gulp tslint
         gulp genAikey
+        mkdir package
+        cd package
         vsce package
     - name: create artifact
       uses: actions/upload-artifact@v1
       with:
         name: vscode-arduino-${{env.VERSION}}.vsix
-        path: ${{github.workspace}}\*.vsix
+        path: package

From ef57ce6106ed3162390cba52cf32ad1e9ae83a26 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 10:12:58 -0800
Subject: [PATCH 42/51] test  ubuntu

---
 .github/workflows/build.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index eafb4092..d953c6b1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -70,6 +70,7 @@ jobs:
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
     - run: echo "VERSION=${GITHUB_REF#refs/tags/*/}" >> $GITHUB_ENV
+    - run: echo VERSION
     - name: Checkout
       uses: actions/checkout@v2
     - name: Get Node
@@ -99,11 +100,9 @@ jobs:
       run: |
         gulp tslint
         gulp genAikey
-        mkdir package
-        cd package
         vsce package
     - name: create artifact
       uses: actions/upload-artifact@v1
       with:
         name: vscode-arduino-${{env.VERSION}}.vsix
-        path: package
+        path: ${{github.workspace}}/*.vsix

From 89a70d3609caaa1bafb6a7431f731c07bf221b39 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 10:35:49 -0800
Subject: [PATCH 43/51] fix tag ref, change to main branch

---
 .github/workflows/build.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d953c6b1..fab74459 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -2,7 +2,7 @@ name: CI-Tests
 on:
   push:
     branches:
-      - actions
+      - master
       - develop
     tags:
       - v*
@@ -69,8 +69,8 @@ jobs:
     runs-on: ubuntu-latest
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
-    - run: echo "VERSION=${GITHUB_REF#refs/tags/*/}" >> $GITHUB_ENV
-    - run: echo VERSION
+    - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+    - run: echo ${{env.VERSION}}
     - name: Checkout
       uses: actions/checkout@v2
     - name: Get Node

From 599b853744655b6bb750f62e1e2b499b245220b4 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 10:56:44 -0800
Subject: [PATCH 44/51] test file path

---
 .github/workflows/build.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index fab74459..44925a6c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -78,7 +78,6 @@ jobs:
       with:
         node-version: 11.x
     - name: linux setup
-      if: ${{ matrix.os == 'ubuntu-latest' }}
       run: |
         export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
         sleep 3
@@ -105,4 +104,4 @@ jobs:
       uses: actions/upload-artifact@v1
       with:
         name: vscode-arduino-${{env.VERSION}}.vsix
-        path: ${{github.workspace}}/*.vsix
+        path: ${{github.workspace}}/vscode-arduino-0.3.4.vsix

From 9c6034d710241d3d20e643bee660c5fb04dd0574 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 11:19:01 -0800
Subject: [PATCH 45/51] test release upload

---
 .github/workflows/build.yml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 44925a6c..bff14052 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -100,8 +100,11 @@ jobs:
         gulp tslint
         gulp genAikey
         vsce package
-    - name: create artifact
-      uses: actions/upload-artifact@v1
+    - name: Upload binaries to release
+      uses: svenstaro/upload-release-action@v2
       with:
-        name: vscode-arduino-${{env.VERSION}}.vsix
-        path: ${{github.workspace}}/vscode-arduino-0.3.4.vsix
+        repo_token: ${{ secrets.OAUTH_TOKEN }}
+        file: ${{github.workspace}}/vscode-arduino*.vsix
+        tag: ${{ github.ref }}
+        overwrite: true
+        file_glob: true

From 5e65d721aa64507d4adca25689ed79d316135230 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 11:29:41 -0800
Subject: [PATCH 46/51] add environment

---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index bff14052..2fc6fd66 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -67,6 +67,7 @@ jobs:
   Package:
     needs: Build
     runs-on: ubuntu-latest
+    environment: Deploy
     # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
     steps:
     - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

From 85f3dae81c40360de7d7e785cbc50e3c82398df1 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 12:02:29 -0800
Subject: [PATCH 47/51] remove arduino install for deploy, add publish

---
 .github/workflows/build.yml | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2fc6fd66..2f6fb715 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -6,7 +6,6 @@ on:
       - develop
     tags:
       - v*
-      - v*.*.*-[a-zA-Z]*
   pull_request:
     branches:
       - master
@@ -14,18 +13,17 @@ on:
 
 
 jobs:
-  Build:
+  build:
 
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
-        # os: [ ubuntu-latest, macos-latest, windows-latest ] 
-        os: [ windows-latest ]
+        os: [ ubuntu-latest, macos-latest, windows-latest ]
     
     steps:
-      - name: Checkout
+      - name: checkout
         uses: actions/checkout@v2
-      - name: Get Node
+      - name: get node
         uses: actions/setup-node@v1
         with:
           node-version: 11.x
@@ -64,17 +62,17 @@ jobs:
         with:
           run: npm test --silent
   
-  Package:
-    needs: Build
+  deploy:
+    needs: build
     runs-on: ubuntu-latest
     environment: Deploy
-    # if: env.VERSION == '!v0.[0-9].[0-9]-[rR]*'
+    if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
     steps:
     - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
     - run: echo ${{env.VERSION}}
     - name: Checkout
       uses: actions/checkout@v2
-    - name: Get Node
+    - name: get node
       uses: actions/setup-node@v1
       with:
         node-version: 11.x
@@ -82,9 +80,6 @@ jobs:
       run: |
         export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0
         sleep 3
-        wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER
-        tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/
-        sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino
         sudo apt-get update
         sudo apt-get install g++-multilib
         sudo apt-get install -y build-essential
@@ -101,7 +96,7 @@ jobs:
         gulp tslint
         gulp genAikey
         vsce package
-    - name: Upload binaries to release
+    - name: upload .vsix to github tag
       uses: svenstaro/upload-release-action@v2
       with:
         repo_token: ${{ secrets.OAUTH_TOKEN }}
@@ -109,3 +104,6 @@ jobs:
         tag: ${{ github.ref }}
         overwrite: true
         file_glob: true
+    - name: publish
+      if: ${{env.VERSION}} == v[0-9].[0-9].[0-9]
+      run: vsce publish -p ${{ secrets.VSCE_TOKEN }}

From 7514a08d1e1ef1305f332bce1cd7719f3b55d7dc Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 12:27:39 -0800
Subject: [PATCH 48/51] fix conditional for publishing

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2f6fb715..b8964284 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -105,5 +105,5 @@ jobs:
         overwrite: true
         file_glob: true
     - name: publish
-      if: ${{env.VERSION}} == v[0-9].[0-9].[0-9]
+      if: github.ref == 'refs/tags/[0-9].[0-9].[0-9]'
       run: vsce publish -p ${{ secrets.VSCE_TOKEN }}

From d7cae752edf322e2b8f3e0a94cbe4efeab97526b Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 12:50:27 -0800
Subject: [PATCH 49/51] update enviroment

---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index b8964284..699aaee2 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -65,7 +65,7 @@ jobs:
   deploy:
     needs: build
     runs-on: ubuntu-latest
-    environment: Deploy
+    environment: vsix-publishing
     if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
     steps:
     - run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

From 44f4b8daf0c32bd81445dd01ae026f360f9a86ce Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Wed, 3 Feb 2021 12:54:09 -0800
Subject: [PATCH 50/51] remove travis.yml

---
 .github/workflows/build.yml |  1 -
 .travis.yml                 | 89 -------------------------------------
 2 files changed, 90 deletions(-)
 delete mode 100644 .travis.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 699aaee2..c2598d3d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -14,7 +14,6 @@ on:
 
 jobs:
   build:
-
     runs-on: ${{ matrix.os }} 
     strategy:
       matrix:
diff --git a/.travis.yml b/.travis.yml
deleted file mode 100644
index 418a1d17..00000000
--- a/.travis.yml
+++ /dev/null
@@ -1,89 +0,0 @@
-language: node_js
-
-node_js:
-- '11'
-
-os:
-- windows
-- linux
-- osx
-dist: trusty # using Ubuntu 14.04.5 LTS
-
-# fixing https://github.com/Microsoft/vscode/issues/33998
-addons:
-  apt:
-    sources:
-      # https://docs.travis-ci.com/user/languages/c/#GCC-on-Linux
-      - ubuntu-toolchain-r-test
-    packages:
-      - libsecret-1-dev
-      - g++-4.9
-
-branches:
-  only:
-  - master
-  - develop
-  - /v?[0-9]+\.[0-9]+\.[0-9]+(.*)?/
-
-env:
-  global:
-    - ISPRODTAG=^v?[0-9]+\.[0-9]+\.[0-9]+$
-
-before_install:
-- if [ $TRAVIS_OS_NAME == "linux" ]; then
-    export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0;
-    sh -e /etc/init.d/xvfb start;
-    sleep 3;
-    wget https://downloads.arduino.cc/arduino-1.8.2-linux64.tar.xz -P /home/$USER;
-    tar -xvf /home/$USER/arduino-1.8.2-linux64.tar.xz -C /home/$USER/;
-    sudo ln -s /home/$USER/arduino-1.8.2/arduino /usr/bin/arduino;
-    sudo apt-get update;
-    sudo apt-get install g++-multilib;
-    sudo apt-get install -y build-essential;
-    sudo apt-get install libudev-dev;
-  fi
-# Arduino 1.8.7 has breaking change, Install board package and library will fail
-# https://github.com/arduino/Arduino/issues/8034
-# Arduino 1.8.8 has fixed issue 8034.
-- if [ $TRAVIS_OS_NAME == "osx" ]; then
-    /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)";
-    brew cask install arduino;
-  fi
-- npm install -g node-gyp
-- npm install -g vsce
-- npm install -g gulp
-- npm install -g typescript
-
-install:
-- npm install
-# https://github.com/travis-ci/travis-ci/issues/8813
-- rm -f ./node_modules/.bin/which
-
-script:
-- gulp tslint
-- gulp genAikey
-- vsce package
-- if [ $TRAVIS_OS_NAME == "linux" ] || [ $TRAVIS_OS_NAME == "osx" ]; then
-    npm test --silent;
-  fi
-
-deploy:
-  # deploy to github release
-  - provider: releases
-    api_key: $GIT_TOKEN
-    file_glob: true
-    file: "*.vsix"
-    skip_cleanup: true
-    on:
-      tags: true
-      all_branches: true
-      condition: "$TRAVIS_OS_NAME == linux"
-  # deploy to vscode extension market
-  - provider: script  
-    script: vsce publish -p $VSCE_TOKEN --packagePath *.vsix
-    skip_cleanup: true
-    on:
-      tags: true
-      all_branches: true
-      # if it's a PROD tag (something like 1.0.0), then publish extension to market.
-      condition: "$TRAVIS_OS_NAME == linux && $TRAVIS_TAG =~ $ISPRODTAG"

From 88c784a7088408d04623ad5aa51493e72893a0a7 Mon Sep 17 00:00:00 2001
From: Adi Azulay <adazulay@microsoft.com>
Date: Thu, 4 Feb 2021 10:59:52 -0800
Subject: [PATCH 51/51] fix tag for stale issue workflow

---
 .github/workflows/stale-issues.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/stale-issues.yml b/.github/workflows/stale-issues.yml
index 1787d9e2..10c0b252 100644
--- a/.github/workflows/stale-issues.yml
+++ b/.github/workflows/stale-issues.yml
@@ -16,7 +16,7 @@ jobs:
         stale-issue-message: 'This issue has been automatically marked as stale because it has no recent activities. It will be closed if no further activity occurs within 3 days. Thank you for your contributions.'
         stale-issue-label: 'stale'
         days-before-stale: 7
-        only-labels: 'need more info'
+        only-labels: 'needs more info'
         last-updated-user-type: 'collaborator'
         days-before-close: 3
         operations-per-run: 150