Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Travis Node.js: 11 job failing #911

Closed
jayvdb opened this issue Oct 15, 2019 · 3 comments
Closed

Travis Node.js: 11 job failing #911

jayvdb opened this issue Oct 15, 2019 · 3 comments
Assignees

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Oct 15, 2019

On #910 I see failures on the Node 11 job only, that look unrelated to the PR changes.

https://travis-ci.org/microsoft/vscode-arduino/jobs/597960540

@hellyzh hellyzh self-assigned this Oct 25, 2019
@hellyzh
Copy link
Contributor

hellyzh commented Oct 31, 2019

The Travis CI build passed now.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 31, 2019

Awesome thanks. Should I rebase my PR, or will it be reviewed as-is?

@jayvdb jayvdb closed this as completed Oct 31, 2019
@hellyzh
Copy link
Contributor

hellyzh commented Nov 1, 2019

No need, we will review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants