Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Support for "arduino" language id #390

Closed
robertohuertasm opened this issue Aug 6, 2017 · 4 comments
Closed

Support for "arduino" language id #390

robertohuertasm opened this issue Aug 6, 2017 · 4 comments

Comments

@robertohuertasm
Copy link

Hi, I'm maintaining vscode-icons and we want to add support for the arduino icon using the language id vscode-icons#1117.

I've seen that there's another extension using the arduino language id (the second one in the store in terms of downloads) and that you decided to drop it in favor of c++ syntax in #167. I was wondering if you could introduce again the language id for us to support the icon linkage easily.

To be honest, I'm not very familiar with the effect of adding this language attribute so it may not be possible for you to keep both the language id and the syntax separated (language id = arduino && syntax = cpp).

@yaohaizh
Copy link
Contributor

yaohaizh commented Aug 7, 2017

Current, this extension is leverage the C++ extension for language service, so we have to keep the language id and syntax to C++. Not sure we can have icon based on the file extension.

@robertohuertasm
Copy link
Author

I thought that maybe you could just provide another id in the languages section of your package.json as currently, you already have arduino-output. Grammar would still be cpp but you would provide arduino as a new language id supporting .ino and .pde.

@robertohuertasm
Copy link
Author

I'll use file extension instead of language id. Don't worry. Thanks!

@yaohaizh
Copy link
Contributor

yaohaizh commented Aug 7, 2017

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants