Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Serial Monitor auto reconnects after build failure. #1289

Closed
Llaves opened this issue Jun 15, 2021 · 4 comments
Closed

Serial Monitor auto reconnects after build failure. #1289

Llaves opened this issue Jun 15, 2021 · 4 comments
Labels
needs-more-info More details about this issue are needed for it to be actionable. serial Issues with serial ports stale

Comments

@Llaves
Copy link

Llaves commented Jun 15, 2021

If the serial monitor was active when the build/upload command is invoked, the monitor is restored when the operation is complete, even if it failed. This occurs at arduino.ts line 722 (I think). The problem is that this immediately hides the build output window and the user may not notice that the build failed, no upload occurred, and they are still running the result of the previous successful upload and left wondering why the new code had no effect.

This conflicts to some degree with issues 1060 and 1061. 1060 points out that if you don't restore the monitor in this case, then the next successful compile will not open the monitor as the recorded state at the start of the compile. This would require some sort of persistent state var rather than just testing to see if the monitor is open at the invocation of the compile. 1061 seems to want the serial monitor to remain open and connected to the device in the event of a failed compile, though I don't understand what the use case for that would be.

@benmcmorran benmcmorran added the serial Issues with serial ports label Jan 12, 2022
@StefanKellerAC
Copy link

Yes, that would be fine!
An acoustic signal would be fine for me:
#1518 (comment)

@gcampbell-msft
Copy link
Contributor

@Llaves We have recently updated the Arduino extension to depend on a new standalone Serial Monitor extension, please upgrade your arduino extension and try out this new feature!

Let us know if it solves your issue or if the issue still persists!

@gcampbell-msft gcampbell-msft added the needs-more-info More details about this issue are needed for it to be actionable. label Feb 16, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has been inactive for 30 days. To reactivate the issue, simply post a comment with the requested information to help us diagnose this issue. If this issue remains inactive for another 7 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Mar 18, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you are still experiencing problems, please open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-more-info More details about this issue are needed for it to be actionable. serial Issues with serial ports stale
Projects
None yet
Development

No branches or pull requests

4 participants