Switch from serial-monitor-cli to node-serialport

Author: benmcmorran

azure-pipelines.yml

@@ -122,12 +122,6 @@ steps:
       msbuildArguments: /p:SignType=$(SignType)
     # MicroBuild signing will always fail on public PRs.
     condition: ne(variables['Build.Reason'], 'PullRequest')
-  # VSIX signing removes the executable attributes on files. Luckily, the
-  # signature only seems to be based on the content of the files, not the
-  # attributes, so we can safely go back and mark the serial monitor as
-  # executable without invalidating the signature.
-  - script: python .\build\markExecutableFiles.py
-    displayName: Make serial monitor executable
   - publish: $(Build.StagingDirectory)\vscode-arduino.vsix
     artifact: VS Code extension VSIX
     displayName: Publish extension VSIX as artifact

build/SignFiles.proj

@@ -13,14 +13,6 @@
     <FilesToSign Include="$(OutDir)\**\*.js" Exclude="$(OutDir)\**\node_modules\**\*.js">
       <Authenticode>Microsoft400</Authenticode>
     </FilesToSign>
-    <!-- Authenticode only works on Windows files. If we get the ability to sign Linux and Mac executables, the signing
-         steps should probably move to the serial-monitor-cli repo instead of doing all the signing here. -->
-    <FilesToSign Include="$(OutDir)\out\serial-monitor-cli\win32\*.exe">
-      <Authenticode>Microsoft400</Authenticode>
-    </FilesToSign>
-    <FilesToSign Include="$(OutDir)\out\serial-monitor-cli\win32\*.dll">
-      <Authenticode>Microsoft400</Authenticode>
-    </FilesToSign>
     <FilesToSign Include="$(OutDir)\**\node_modules\**\*.js">
       <Authenticode>3PartyScriptsSHA2</Authenticode>
     </FilesToSign>

build/markExecutableFiles.py

@@ -63,28 +63,6 @@ gulp.task("node_modules-webpack", (done) => {
     });
 });
 
-gulp.task("insert-serial-monitor-cli", async (done) => {
-    const platforms = [
-        "linux",
-        "darwin",
-        "win32",
-    ];
-    const release = "latest";
-    const destDir = path.resolve("out", "serial-monitor-cli");
-
-    async function downloadAndUnzip(platform) {
-        const fileName = `${platform}.zip`;
-        const zipPath = path.join(destDir, fileName);
-        await download(`https://github.com/microsoft/serial-monitor-cli/releases/${release}/download/${fileName}`,
-                       destDir,
-                       );
-        await extract(zipPath, { dir: path.join(destDir, platform) });
-        fs.rmSync(zipPath);
-    }
-
-    Promise.all(platforms.map(downloadAndUnzip)).then(done);
-});
-
 gulp.task("ts-compile", () => {
     const tsProject = ts.createProject("./tsconfig.json");
     return tsProject.src()
@@ -156,7 +134,7 @@ gulp.task("test", (done) => {
     });
 });
 
-gulp.task("build", gulp.series("clean", "ts-compile", "html-webpack", "node_modules-webpack", "insert-serial-monitor-cli"));
+gulp.task("build", gulp.series("clean", "ts-compile", "html-webpack", "node_modules-webpack"));
 
 gulp.task("build_without_view", gulp.series("clean", "ts-compile"));