Address PR comments

Author: benmcmorran

.github/workflows/build.yml

@@ -73,9 +73,7 @@ jobs:
 
       - name: Check for linting errors
         run: gulp tslint
-      - name: Build extension
-        run: gulp build --mode=production
-      - name: Pack extension
+      - name: Build and pack extension
         run: vsce package --out vscode-arduino.vsix
       - name: Publish extension VSIX as artifact
         uses: actions/upload-artifact@v2

azure-pipelines.yml

@@ -78,13 +78,11 @@ steps:
   - script: gulp genAikey
     displayName: Use production AI key
     condition: and(succeeded(), startsWith(variables['Build.SourceBranch'], 'refs/tags'))
-  - script: gulp build --mode=production
-    displayName: Build extension
   # Pack the extension now even though it's unsigned so that we ignore files
   # from .vscodeignore. This will reduce load on the signing server later and
   # ensure we only attempt to sign shipping files.
   - script: vsce package --out vscode-arduino.vsix
-    displayName: Pack extension
+    displayName: Build and pack extension
 
   - task: ComponentGovernanceComponentDetection@0
     displayName: Detect components

build/SignFiles.proj

@@ -13,6 +13,8 @@
     <FilesToSign Include="$(OutDir)\**\*.js" Exclude="$(OutDir)\**\node_modules\**\*.js">
       <Authenticode>Microsoft400</Authenticode>
     </FilesToSign>
+    <!-- Authenticode only works on Windows files. If we get the ability to sign Linux and Mac executables, the signing
+         steps should probably move to the serial-monitor-cli repo instead of doing all the signing here. -->
     <FilesToSign Include="$(OutDir)\out\serial-monitor-cli\win32\*.exe">
       <Authenticode>Microsoft400</Authenticode>
     </FilesToSign>

package.json

@@ -571,6 +571,7 @@
     ]
   },
   "scripts": {
+    "vscode:prepublish": "gulp build --mode=production",
     "postinstall": "cd ./src/views && npm install && node ../../node_modules/node-usb-native/scripts/rebuild-serialport.js",
     "test": "gulp test"
   },