fix bug: libPath contains environment variables on win32 (#175)

* fix bug: libPath contains environment variables on win32

* move fix code to docFolder

Author: testforstephen

html/app/styles/board.scss

@@ -146,7 +146,7 @@ a {
 
     .toolbar-mask {
         position: absolute;
-        z-index: 9999;
+        z-index: 9998;
         left: 20px;
         right: 20px;
         text-align: end;

src/arduino/arduino.ts

@@ -180,10 +180,15 @@ export class ArduinoApp {
     public async installBoard(packageName: string, arch: string, version: string = "", showOutput: boolean = true) {
         arduinoChannel.show();
         arduinoChannel.start(`Install package - ${packageName}...`);
-        await util.spawn(this._settings.commandPath,
-            showOutput ? arduinoChannel.channel : null,
-            ["--install-boards", `${packageName}:${arch}${version && ":" + version}`]);
-        arduinoChannel.end(`Installed board package - ${packageName}${os.EOL}`);
+        try {
+            await util.spawn(this._settings.commandPath,
+                showOutput ? arduinoChannel.channel : null,
+                ["--install-boards", `${packageName}:${arch}${version && ":" + version}`]);
+
+            arduinoChannel.end(`Installed board package - ${packageName}${os.EOL}`);
+        } catch (error) {
+            arduinoChannel.error(`Exit with code=${error.code}${os.EOL}`);
+        }
     }
 
     public uninstallBoard(boardName: string, packagePath: string) {
@@ -195,11 +200,15 @@ export class ArduinoApp {
     public async installLibrary(libName: string, version: string = "", showOutput: boolean = true) {
         arduinoChannel.show();
         arduinoChannel.start(`Install library - ${libName}`);
-        await util.spawn(this._settings.commandPath,
-            showOutput ? arduinoChannel.channel : null,
-            ["--install-library", `${libName}${version && ":" + version}`]);
+        try {
+            await util.spawn(this._settings.commandPath,
+                showOutput ? arduinoChannel.channel : null,
+                ["--install-library", `${libName}${version && ":" + version}`]);
 
-        arduinoChannel.end(`Installed libarray - ${libName}${os.EOL}`);
+            arduinoChannel.end(`Installed library - ${libName}${os.EOL}`);
+        } catch (error) {
+            arduinoChannel.error(`Exit with code=${error.code}${os.EOL}`);
+        }
     }
 
     public uninstallLibrary(libName: string, libPath: string) {

src/arduino/settings.ts

@@ -167,7 +167,12 @@ export class ArduinoSettings implements IArduinoSettings {
                 resolve(docFolder);
             }
         }).then((folder: string) => {
-            this._libPath = path.join(folder, "Arduino/libraries");
+            // For some case, docFolder parsed from win32 registry looks like "%USERPROFILE%\Documents,
+            // Should replace the environment variables with actual value.
+            folder = folder.replace(/%([^%]+)%/g, (match, p1) => {
+                return process.env[p1];
+            });
+            this._libPath = path.normalize(path.join(folder, "Arduino/libraries"));
             if (util.fileExistsSync(path.join(arduinoPath, "AppxManifest.xml"))) {
                 this._packagePath = path.join(folder, "ArduinoData");
             } else {