@@ -32,6 +32,7 @@ export class SerialMonitor implements vscode.Disposable {
32
32
private extensionContext : vscode . ExtensionContext ;
33
33
private currentPort : string ;
34
34
private activePort : Port | undefined ;
35
+ private lastSelectedBaudRate : number = 9600 ; // arbitrary default.
35
36
36
37
private openPortStatusBar : vscode . StatusBarItem ;
37
38
private portsStatusBar : vscode . StatusBarItem ;
@@ -126,10 +127,11 @@ export class SerialMonitor implements vscode.Disposable {
126
127
return undefined ;
127
128
}
128
129
const selectedRate : number = parseInt ( chosen , 10 ) ;
130
+ this . lastSelectedBaudRate = selectedRate ;
129
131
return selectedRate ;
130
132
}
131
133
132
- public async openSerialMonitor ( ) : Promise < void > {
134
+ public async openSerialMonitor ( restore : boolean = false ) : Promise < void > {
133
135
if ( ! this . currentPort ) {
134
136
const ans = await vscode . window . showInformationMessage ( "No serial port was selected, please select a serial port first" , "Yes" , "No" ) ;
135
137
if ( ans === "Yes" ) {
@@ -142,7 +144,8 @@ export class SerialMonitor implements vscode.Disposable {
142
144
}
143
145
}
144
146
145
- const baudRate = await this . selectBaudRate ( ) ;
147
+ // if we're restoring, we want to use the most recent baud rate selected, rather than popping UI.
148
+ const baudRate = restore ? this . lastSelectedBaudRate : await this . selectBaudRate ( ) ;
146
149
147
150
if ( ! baudRate ) {
148
151
return ;
@@ -168,11 +171,10 @@ export class SerialMonitor implements vscode.Disposable {
168
171
}
169
172
170
173
public async closeSerialMonitor ( port ?: string ) : Promise < boolean > {
171
- await this . serialMonitorApi . stopMonitoringPort ( port ?? this . currentPort ) ;
174
+ const closed = await this . serialMonitorApi . stopMonitoringPort ( port ?? this . currentPort ) ;
172
175
this . updatePortStatus ( false ) ;
173
176
174
- // TODO: Update API to return a boolean acknowledging whether monitor session was closed.
175
- return true ;
177
+ return closed ;
176
178
}
177
179
178
180
public dispose ( ) {
0 commit comments