Merge pull request #1593 from microsoft/dev/gcampbell/FixErrorMessage

gcampbell-msft · web-flow · commit 75a0cc4c6bcd · 2023-02-16T13:56:00.000-05:00
fix the error message to output the message, not the object
diff --git a/src/serialmonitor/serialMonitor.ts b/src/serialmonitor/serialMonitor.ts
@@ -144,7 +144,9 @@ export class SerialMonitor implements vscode.Disposable {
             this.updatePortStatus(true);
         } catch (err) {
             Logger.warn("Serial Monitor failed to open");
-            vscode.window.showErrorMessage(`Error opening serial port: ${err.toString()}`);
+            if (err.message) {
+                vscode.window.showErrorMessage(`Error opening serial port: ${err.message}`);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,9 @@ export class SerialMonitor implements vscode.Disposable {`
`144`	`144`	`this.updatePortStatus(true);`
`145`	`145`	`} catch (err) {`
`146`	`146`	`Logger.warn("Serial Monitor failed to open");`
`147`		- vscode.window.showErrorMessage(`Error opening serial port: ${err.toString()}`);
	`147`	`+ if (err.message) {`
	`148`	+ vscode.window.showErrorMessage(`Error opening serial port: ${err.message}`);
	`149`	`+ }`
`148`	`150`	`}`
`149`	`151`	`}`
`150`	`152`