filter folders when parsing libraries

Author: testforstephen

src/arduino/boardManager.ts

@@ -348,11 +348,11 @@ export class BoardManager {
 
     private loadInstalledPlatforms(): void {
         this._installedPlatforms = [];
-        let rootPacakgesPath = path.join(path.join(this._settings.packagePath, "packages"));
-        if (!util.directoryExistsSync(rootPacakgesPath)) {
+        let rootPackagePath = path.join(path.join(this._settings.packagePath, "packages"));
+        if (!util.directoryExistsSync(rootPackagePath)) {
             return;
         }
-        const dirs = util.filterJunk(fs.readdirSync(rootPacakgesPath)); // in Mac, filter .DS_Store file.
+        const dirs = util.filterJunk(util.readdirSync(rootPackagePath, true)); // in Mac, filter .DS_Store file.
         dirs.forEach((packageName) => {
             let archPath = path.join(this._settings.packagePath, "packages", packageName, "hardware");
             if (!util.directoryExistsSync(archPath)) {

src/arduino/libraryManager.ts

@@ -87,7 +87,7 @@ export class LibraryManager {
         if (os.platform() === "darwin") {
             ideLibraryPath = path.join(arduinoPath, "Arduino.app/Contents/Java/libraries");
         }
-        const ideLibraries = util.filterJunk(fs.readdirSync(ideLibraryPath));
+        const ideLibraries = util.filterJunk(util.readdirSync(ideLibraryPath, true));
         for (let libDir of ideLibraries) {
             if (util.fileExistsSync(path.join(ideLibraryPath, libDir, "library.properties"))) {
                 const properties = <any>await util.parseProperties(path.join(ideLibraryPath, libDir, "library.properties"));
@@ -112,7 +112,7 @@ export class LibraryManager {
             return;
         }
 
-        let installedLibDirs = util.filterJunk(fs.readdirSync(libRoot));
+        let installedLibDirs = util.filterJunk(util.readdirSync(libRoot, true));
         for (let libDir of installedLibDirs) {
             if (util.fileExistsSync(path.join(libRoot, libDir, "library.properties"))) {
                 const properties = <any>await util.parseProperties(path.join(libRoot, libDir, "library.properties"));
@@ -147,7 +147,7 @@ export class LibraryManager {
         let builtInLib = [];
         let builtInLibPath = path.join(rootBoardPath, "libraries");
         if (util.directoryExistsSync(builtInLibPath)) {
-            let libDirs = util.filterJunk(fs.readdirSync(builtInLibPath));
+            let libDirs = util.filterJunk(util.readdirSync(builtInLibPath, true));
             if (!libDirs || !libDirs.length) {
                 return builtInLib;
             }

src/common/util.ts

@@ -51,6 +51,24 @@ export function directoryExistsSync(dirPath: string): boolean {
     }
 }
 
+/**
+ * This function will implement same function as fs.readdirSync,
+ * besides it could filter folders when the second argument is true.
+ * @function readdirSync
+ * @argument {string} dirPath
+ * @argument {boolean} folderOnly
+ */
+export function readdirSync(dirPath: string, folderOnly: boolean = false): string[] {
+    const dirs = fs.readdirSync(dirPath);
+    if (folderOnly) {
+        return dirs.filter((subdir) => {
+            return directoryExistsSync(path.join(dirPath, subdir));
+        });
+    } else {
+        return dirs;
+    }
+}
+
 export function mkdirRecursivelySync(dirPath: string): void {
     if (directoryExistsSync(dirPath)) {
         return ;