Skip to content

Commit 8497483

Browse files
Handle the case where the FAR results map is empty (#49254)
* Handle the case where the FAR results map is empty Searching exactly one project does not imply the presence of exactly one references list. Fixes #49217 * Use emptyArray Co-authored-by: Sheetal Nandi <[email protected]> Co-authored-by: Sheetal Nandi <[email protected]>
1 parent 77ffb96 commit 8497483

7 files changed

+40
-2
lines changed

src/server/session.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -575,8 +575,7 @@ namespace ts.server {
575575
// it easier for the caller to skip post-processing.
576576
if (searchedProjects.size === 1) {
577577
const it = resultsMap.values().next();
578-
Debug.assert(!it.done);
579-
return it.value;
578+
return it.done ? emptyArray : it.value; // There may not be any results at all
580579
}
581580

582581
return resultsMap;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
[
2+
{
3+
"definition": {
4+
"containerKind": "",
5+
"containerName": "",
6+
"fileName": "/tests/cases/fourslash/server/referencesToStringLiteralValue.ts",
7+
"kind": "var",
8+
"name": "some string",
9+
"textSpan": {
10+
"start": 19,
11+
"length": 12
12+
},
13+
"displayParts": [
14+
{
15+
"text": "\"some string\"",
16+
"kind": "stringLiteral"
17+
}
18+
]
19+
},
20+
"references": []
21+
}
22+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/// <reference path='fourslash.ts'/>
2+
3+
////const obj = {}/*1*/;
4+
5+
verify.baselineFindAllReferences('1');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/// <reference path='fourslash.ts'/>
2+
3+
/////*1*/
4+
5+
verify.baselineFindAllReferences('1');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/// <reference path='fourslash.ts'/>
2+
3+
////const s: string = "some /*1*/ string";
4+
5+
verify.baselineFindAllReferences('1');

0 commit comments

Comments
 (0)