Wrong removeEventListener() parameters

[tkrotoff]

Current definition:

addEventListener(type: string, listener?: EventListenerOrEventListenerObject, useCapture?: boolean): void;
removeEventListener(type: string, listener?: EventListenerOrEventListenerObject, useCapture?: boolean): void;

Should be something like:

interface AddEventListenerOptions {
  capture?: boolean;
  once?: boolean;
  passive?: boolean;
}

interface RemoveEventListenerOptions {
  capture?: boolean;
  passive?: boolean;
}

interface EventTarget {
  addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: AddEventListenerOptions): void;
  addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
  removeEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
  removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: RemoveEventListenerOptions): void;
}

listener is mandatory.

See addEventListener and removeEventListener:

target.addEventListener(type, listener[, options]);
target.addEventListener(type, listener[, useCapture]);

target.removeEventListener(type, listener[, options]);
target.removeEventListener(type, listener[, useCapture]);

Example:

var listener = function() {
  console.log('Hello!');
}

document.body.addEventListener('click', listener);

document.body.click(); // Hello!

document.body.removeEventListener('click'); // BOOM! =>
/* Under Chrome 55:
Uncaught TypeError: Failed to execute 'removeEventListener' on 'EventTarget': 2 arguments required, but only 1 present.
*/

/* Under Firefox 47
TypeError: Not enough arguments to EventTarget.removeEventListener.
*/

document.body.addEventListener('click'); // BOOM! =>
/* Under Chrome 55:
Uncaught TypeError: Failed to execute 'addEventListener' on 'EventTarget': 2 arguments required, but only 1 present.
*/

[saschanaz]

Partially fixed by #224 but the listener is still optional.

[saschanaz]

Has been fixed since then.

@github-actions close

[github-actions]

Closing because @saschanaz is one of the code-owners of this repository.