Skip to content

Wrong type for pushsubscriptionchange / onpushsubscriptionchange #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkasten2 opened this issue Feb 24, 2023 · 1 comment
Open

Wrong type for pushsubscriptionchange / onpushsubscriptionchange #1504

jkasten2 opened this issue Feb 24, 2023 · 1 comment

Comments

@jkasten2
Copy link

jkasten2 commented Feb 24, 2023

One Line Summary

pushsubscriptionchange is currently defined as Event when it should be it's own type defined by PushSubscriptionChangeEvent in the w3c spec.

Background

PR "#944 -Remove unimplemented PushSubscriptionChangeEvent" removed PushSubscriptionChangeEvent under the wrong assumption that browsers don't support this. However it was later commented that this is supported, noted in mdn/browser-compat-data#6715 (comment). Then pushsubscriptionchange was later re-added as the wrong type in (Event) #1365

@saschanaz
Copy link
Contributor

saschanaz commented Mar 17, 2023

Well it's weird, because onpushsubscriptionchange exists in both Blink and Gecko while Gecko does not support PushSubscriptionChangeEvent: https://bugzilla.mozilla.org/show_bug.cgi?id=1497429, https://wpt.fyi/results/push-api/idlharness.https.any.serviceworker.html?label=experimental&label=master&aligned&view=subtest

That's why the event interface does not exist but only the event handler. I'd rather remove it for now as it's essentially Blink only for now. It seems the handler itself works in Gecko. 🤔

For MDN I'll file another issue. mdn/browser-compat-data#19162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants