Skip to content

Let OSS-Docs-Tools/code-owner-self-merge use Personal Access Token #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saschanaz opened this issue Aug 14, 2021 · 3 comments
Closed

Let OSS-Docs-Tools/code-owner-self-merge use Personal Access Token #1103

saschanaz opened this issue Aug 14, 2021 · 3 comments

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Aug 14, 2021 •
edited
Loading

Merging by secrets.GITHUB_TOKEN does not fire workflows, see https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs

I think it should also use TS_GITHUB_BOT_AUTH, but I guess it would need a write access in that case?
@orta
Copy link
Contributor

orta commented Aug 17, 2021

This makes sense, I think we can solve this with a nightly scheduled run of the CI! The deploy scripts would NOOP today if there are no changes anyway.

It's what I do for https://github.com/tsconfig/bases

@saschanaz
Copy link
Contributor Author

Doing nightly runs sounds good to me

@orta
Copy link
Contributor

orta commented Aug 18, 2021

That worked this morning

@orta orta closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orta @saschanaz